-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add options to skip operations for RestoreLabeld Transform #8125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hsin Tong <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Hsin-Tong Hsieh <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]> Signed-off-by: Hsin-Tong Hsieh <[email protected]>
Signed-off-by: Hsin-Tong Hsieh <[email protected]>
Hi @ericspod , Thanks for the suggestion. I've fixed the suggestions mentioned above, and I've also standardized the parameter names to |
Signed-off-by: Hsin Tong <[email protected]>
Signed-off-by: Hsin Tong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some minor test-related suggestions but otherwise I think this is fine. I will ask @KumoLiu to review and enable blossom as well. Thanks!
Signed-off-by: kbbbbkb <[email protected]>
Signed-off-by: kbbbbkb <[email protected]>
Add DATA_13 and 3 test cases for RestoreLabeld.
for more information, see https://pre-commit.ci
Signed-off-by: Hsin Tong <[email protected]>
Signed-off-by: Hsin Tong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, LGTM.
/build |
Fixes #6380
Description
Four new bool parameters are added into
RestoreLabeld
to allow users to selectively enable or disable each restoration operation as needed, and a corresponding test case is added to verify that the function runs correctly.This design allows users to selectively enable or disable each restoration operation as needed, providing greater flexibility.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.