Skip to content

Add options to skip operations for RestoreLabeld Transform #8125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 12, 2024

Conversation

ctongh
Copy link
Contributor

@ctongh ctongh commented Oct 1, 2024

Fixes #6380

Description

Four new bool parameters are added into RestoreLabeld to allow users to selectively enable or disable each restoration operation as needed, and a corresponding test case is added to verify that the function runs correctly.

This design allows users to selectively enable or disable each restoration operation as needed, providing greater flexibility.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

ctongh and others added 3 commits October 2, 2024 14:40
Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: Hsin-Tong Hsieh <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: Hsin-Tong Hsieh <[email protected]>
@ctongh
Copy link
Contributor Author

ctongh commented Oct 2, 2024

Hi @ericspod , Thanks for the suggestion. I've fixed the suggestions mentioned above, and I've also standardized the parameter names to restore_resizing, restore_cropping, restore_spacing, restore_slicing, I'm not sure if that's a good setting.

@ctongh ctongh marked this pull request as ready for review October 2, 2024 09:38
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some minor test-related suggestions but otherwise I think this is fine. I will ask @KumoLiu to review and enable blossom as well. Thanks!

@ericspod ericspod requested a review from KumoLiu October 4, 2024 13:41
Kbinn and others added 6 commits October 10, 2024 00:41
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@KumoLiu
Copy link
Contributor

KumoLiu commented Oct 11, 2024

/build

@ericspod ericspod merged commit 796271c into Project-MONAI:dev Oct 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to skip resizing for RestoreLabeld Transform
4 participants