fix: scheduler ignore KUBECONFIG env even if this environment variable is set #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Shouren
force-pushed
the
fix/k8s-client-for-scheduler
branch
3 times, most recently
from
ae54f90 to
dda05c5
Compare
Shouren
changed the title
Shouren
force-pushed
the
fix/k8s-client-for-scheduler
branch
4 times, most recently
from
57fee3a to
4aae789
Compare
lengrongfu
reviewed
Dec 6, 2024
pkg/scheduler/scheduler.go
Outdated
| @@ -125,7 +126,7 @@ func (s *Scheduler) onDelPod(obj interface{}) { | |||
| } | |||
|
|
|||
| func (s *Scheduler) Start() { | |||
| kubeClient, err := k8sutil.NewClient() | |||
| kubeClient, err := client.NewClient() | |||
There was a problem hiding this comment.
you can use client.GetClient() to get kubeClient, because this kubeClient having init function Initialization completed.
There was a problem hiding this comment.
Good idea. By doing so, some the unused code can also be removed
|
suggest title: fix: scheduler ignore KUBECONFIG env even if this environment variable is set |
Shouren
changed the title
Shouren
force-pushed
the
fix/k8s-client-for-scheduler
branch
3 times, most recently
from
7e05044 to
2637cf5
Compare
|
@Shouren can you rebase main branch? because having resolve code lint question. |
…il/client in pkg/scheduler/scheduler.go Signed-off-by: Shouren Yang <[email protected]>
Shouren
force-pushed
the
fix/k8s-client-for-scheduler
branch
from
2637cf5 to
09448b9
Compare
@lengrongfu All right, rebase is done. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The implementation of
NewClientfunction inpkg/k8sutil/client.gogets*restclient.ConfigfromInClusterConfigapi first even if theKUBECONFIGenv has been set which is out of expect. This PR fix it.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: