Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 136b #169

Open
wants to merge 32 commits into
base: dev
Choose a base branch
from
Open

Issue 136b #169

wants to merge 32 commits into from

Conversation

juliobertolacini
Copy link

@juliobertolacini juliobertolacini commented Nov 19, 2016 •
edited
Loading

Branch issue-136b [Work in progress]

Issue 136 - Melhorar a qualidade da classe servico/NotificacaoService.java

Description: Observar comentários do Codacy e melhorar a qualidade da classe NotificacaoService.java
Submitted by: @YsabelleSousa

  • Status: [Not ready to merge] -> branch/dev
  • Description: Opening a pull request for branch/dev just to check Codacy reports.
  • A pedido do Prof. @calebepb, estou trabalhando novamente em uma issue já atribuída a outro aluno.

@juliobertolacini juliobertolacini added this to the v0.2 milestone Nov 19, 2016
@juliobertolacini juliobertolacini self-assigned this Nov 19, 2016
@juliobertolacini juliobertolacini mentioned this pull request Nov 19, 2016
Open
@juliobertolacini juliobertolacini changed the title [WIP] Issue 136b Issue 136b Nov 19, 2016
@juliobertolacini juliobertolacini changed the title Issue 136b [WIP] Issue 136b Nov 20, 2016
@juliobertolacini juliobertolacini changed the title [WIP] Issue 136b Issue 136b Nov 20, 2016
@juliobertolacini
Copy link
Author

juliobertolacini commented Nov 25, 2016 •
edited
Loading

Branch issue-136b [Finished]

Issue 136 - Melhorar a qualidade da classe src/servico/NotificacaoService.java

Description: Observar comentários do Codacy e melhorar a qualidade da classe NotificacaoService.java
Submitted by: @YsabelleSousa

  • Status: [Ready to merge] -> branch/dev

  • Accomplished activities:

    • src/servico/NotificacaoService.java -> class refactored
    • src/servico/package-info.java -> javadoc file created for the "servico" package

  • Codacy class grades:

    Grade Filename
    A src/servico/NotificacaoService.java
    A src/servico/package-info.java

  • Total commits: 16

@calebepb calebepb mentioned this pull request May 26, 2017
Closed
juliobertolacini and others added 16 commits May 26, 2017 11:02
@juliobertolacini @calebepb
Fixing "Avoid unused imports" alert (01)
8b3e8f4
@juliobertolacini @calebepb
Fixing identations and spaces (01)
df7f9f5 
"'{' is not preceded with whitespace." alert,
"'for' is not followed by whitespace." alert,
"'if' construct must use '{}'s." alert,
"'if' is not followed by whitespace." alert,
"'else' construct must use '{}'s. alert
@juliobertolacini @calebepb
Fixing "Missing a Javadoc comments. (01)"
ba8a4fd
@juliobertolacini @calebepb
Fixing "Reference to instance variable needs "this." (01)
2dcb14e
@juliobertolacini @calebepb
Fixing "Missing a Javadoc comments" (02)
575ccc1 
"Line is longer than 120 characters." alert
@juliobertolacini @calebepb
Fixing magic numbers and duplicates (01)
ff9a4bd
@juliobertolacini @calebepb
Fixing duplicates and syntax (01)
f4a8692
@juliobertolacini @calebepb
Fixing package-info.java file and javadocs (01)
fd4c41b
@calebepb
Fixing package-info.java file and javadocs (02)
d680d1e
@calebepb
Revert "Fixing package-info.java file and javadocs (02)"
7a0ccec 
This reverts commit af67e86.
@juliobertolacini @calebepb
Fixing package-info.java file and javadocs (02)
1d2c782
@juliobertolacini @calebepb
Fixing javadocs (01)
fe5f6c0
@juliobertolacini @calebepb
Fixing javadocs (02)
d94158b
@juliobertolacini @calebepb
Fixing javadocs (03)
7a83d32
@calebepb
Fixing javadocs (04)
6e8e62d
@juliobertolacini @calebepb
Fixing javadocs (05)
413cc10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brunoalbrito brunoalbrito

@juliobertolacini juliobertolacini

Labels
enhancement tests & QA
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@juliobertolacini @brunoalbrito