Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19658 | Icon Selection Closes Card Prematurely In Template Details Page #1750

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Oct 21, 2024

Issue

Ticket: FOUR-19658

When a user selects an icon in the template details page, the card closes automatically. This interrupts the user flow, preventing them from making additional selections or adjustments. The card should remain open until the user explicitly selects the 'Cancel' button.

Solution

  • Set checkbox value when icon is selected.
  • Stop event propagation when icon is selected.
  • Stop event propagation when 'Cancel' button is selected.

How to Test

  1. Go to branch observation/FOUR-19658 in screen-builder.
  2. Go to Designer → Screens. Open a Screen to edit.
  3. Select 'Templates' from the top menu bar. Select a template card.
  4. When the template card opens:
    • Select an icon; the corresponding checkbox should be selected. The card should not close.
    • Select the cancel button; the card should close and any selected options should clear.

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

Copy link

cypress bot commented Oct 21, 2024

screen-builder    Run #1566

Run Properties:  status check passed Passed #1566  •  git commit f6ab620be4: FOUR-19658 | Icon Selection Closes Card Prematurely In Template Details Page
Project screen-builder
Branch Review observation/FOUR-19658
Run status status check passed Passed #1566
Run duration 08m 11s
Commit git commit f6ab620be4: FOUR-19658 | Icon Selection Closes Card Prematurely In Template Details Page
Committer Teisha McRae
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 331
View all changes introduced in this branch ↗︎

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-59b3f7a8bd.engk8s.processmaker.net

@ryancooley ryancooley merged commit 98fb3d8 into release-2024-fall Oct 21, 2024
15 checks passed
@ryancooley ryancooley deleted the observation/FOUR-19658 branch October 21, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants