Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19611: Remove control from clipboard when the related control property is modified #1749

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

rodriquelca
Copy link
Contributor

Issue & Reproduction Steps

Expected behavior:
Remove control from clipboard when the related control property is modified
Actual behavior:
if the user updated a control property the control was not deleted from clipboard

Solution

  • add a method to manage control config updates and if there are diferences update the uuid
control_property_remove_clipboard.mov

How to Test

Test the steps above

detailed in the test

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 21, 2024

screen-builder    Run #1574

Run Properties:  status check passed Passed #1574  •  git commit ac4c216823: FOUR-19611: Remove control from clipboard when the related control property is m...
Project screen-builder
Branch Review bugfix/FOUR-19611
Run status status check passed Passed #1574
Run duration 08m 27s
Commit git commit ac4c216823: FOUR-19611: Remove control from clipboard when the related control property is m...
Committer rodrigo
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

Copy link
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ryancooley ryancooley merged commit 6f8c28a into release-2024-fall Oct 22, 2024
15 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-19611 branch October 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants