Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/FOUR-18114:STORY Record List from Collections UI Update) #1740

Merged
merged 24 commits into from
Oct 22, 2024

Conversation

CarliPinell
Copy link
Contributor

@CarliPinell CarliPinell commented Oct 14, 2024

How to Test

  • Login PM4
  • Go to Designer->Screens
  • Create or Update some screen
  • Drag Record List control
  • Select a Variable or Collection
  • Add some columns
  • Go to DESIGN tab and choose "Modern" in dropdown Table Style
  • Click on Preview(Classic Mode should display Table as always, and Modern mode should display new Styles)

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-18114

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

cypress bot commented Oct 14, 2024

screen-builder    Run #1589

Run Properties:  status check passed Passed #1589  •  git commit 3d1db8d822: Feature/FOUR-18114:STORY Record List from Collections UI Update)
Project screen-builder
Branch Review feature/FOUR-18114
Run status status check passed Passed #1589
Run duration 08m 33s
Commit git commit 3d1db8d822: Feature/FOUR-18114:STORY Record List from Collections UI Update)
Committer CarliPinell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 19
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 331
View all changes introduced in this branch ↗︎

Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@boliviacoca
Copy link
Contributor

Green moving to Final review.

@ryancooley ryancooley merged commit 9ec89bd into release-2024-fall Oct 22, 2024
15 checks passed
@ryancooley ryancooley deleted the feature/FOUR-18114 branch October 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants