Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19905 Show lock icon on remote bundle assets #7666

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

nolanpro
Copy link
Collaborator

@nolanpro nolanpro commented Oct 31, 2024

Issue & Reproduction Steps

See jira issue

Solution

  • In the Jira ticket, I believe Scenario A is working as expected so there are no changes.
  • Show lock icon on remote bundle assets (Scenario B)
  • Do not show remote bundles when viewing the instance bundles. This was not mentioned in the Jira issue but I saw it in the Figma screen capture description (text in pink box)

How to Test

See jira issue

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
image

@ryancooley ryancooley merged commit 7bc3f3a into release-2024-fall Nov 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants