Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19808 only active tasks should be selectable to open #7649

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

devmiguelangel
Copy link
Contributor

@devmiguelangel devmiguelangel commented Oct 29, 2024

Issue & Reproduction Steps

Currently, the ellipsis in the 'task' column displays all tasks (both closed and open), and you can select any of them.

Solution

  • Add status value to cases tasks
  • Update status value of the cases tasks

How to Test

Describe how to test that this solution works.

Related Tickets & Packages

FOUR-19808

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@devmiguelangel devmiguelangel self-assigned this Oct 29, 2024
@caleeli
Copy link
Contributor

caleeli commented Oct 30, 2024

@devmiguelangel seems here is missing the status field:

at: ProcessMaker/Repositories/CaseSyncRepository.php
image

@pmPaulis
Copy link
Contributor

pmPaulis commented Oct 30, 2024

@caleeli
I can review with new Cases that all the API's is return information about the status, this was approved
API:

api/1.1/cases/get_all_cases?pageSize=15&page=1&userId=1&filterBy=[]&sortBy=case_number:desc
api/1.1/cases/get_in_progress
api/1.1/cases/get_completed
api/1.1/cases/get_all_cases?pageSize=15&page=1&filterBy=[]&sortBy=case_number:desc
"tasks": [
                {
                    "id": "321",
                    "name": "Form Task C",
                    "status": "ACTIVE",
                    "element_id": "node_34",
                    "process_id": 41
                },
                {
                    "id": "320",
                    "name": "Form Task B",
                    "status": "ACTIVE",
                    "element_id": "node_24",
                    "process_id": 41
                },
                {
                    "id": "319",
                    "name": "Form Task A",
                    "status": "ACTIVE",
                    "element_id": "node_14",
                    "process_id": 41
                },
                {
                    "id": "317",
                    "name": "Form Task",
                    "status": "COMPLETED",
                    "element_id": "node_2",
                    "process_id": 41
                }
            ],

@ryancooley ryancooley merged commit aff5f43 into release-2024-fall Oct 30, 2024
7 checks passed
@devmiguelangel devmiguelangel deleted the FOUR-19808 branch October 30, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants