Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-19671: Selection Applies Both Fields and Layout to Screen #7621

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

estebangallego
Copy link
Contributor

@estebangallego estebangallego commented Oct 24, 2024

Issue & Reproduction Steps

When selecting only the "Fields" option to apply to a screen, both the fields and the layout from the template are applied. The expected behavior is that only the fields should be applied.

Steps to Reproduce:

  • Create a screen template with both fields and a specific layout.
  • Create a new screen.
  • Use the "Apply Template" option and select only the "Fields" to apply.
    Observe that both the fields and layout are applied to the screen.

Expected Behavior

When selecting the "Fields" option, only the fields from the selected template should be applied to the screen.

Current Behavior

Selecting "Fields" applies both the fields and the layout of the template.

Solution

  • Implement removeFormMultiColumns function that will remove all components === 'FormMultiColumn'

How to Test

Please follow the reproduction steps and make sure that the expected behavior is met.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-85e9d7bf73.engk8s.processmaker.net

@mcraeteisha mcraeteisha self-requested a review October 24, 2024 16:42
@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-85e9d7bf73.engk8s.processmaker.net

Copy link
Contributor

@mcraeteisha mcraeteisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ryancooley ryancooley merged commit 6eac7fd into release-2024-fall Oct 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants