-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOUR-18762: Added PI Process Import to New Process modal #7319
Conversation
return this.$t('Import Process'); | ||
}, | ||
subtitle() { | ||
return this.$t('Import a process from Workfellow PI (.jpg, .jpeg, .png) to this ProcessMaker environment'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text is not the same as the Figma. Should be:
Import a process from Workfellow PI to this ProcessMaker environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In sync with Claudia Iriarte and Franz Villaroel this text was to be included here to indicate the file type that the import accepts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file type should be JSON. Also need to update the figma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we included into SelectTemplateModal? The name is confusing. Maybe we should have our own selectImportPIModal, or change the names to make it reusable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was to keep consistency with how the other 2 buttons (Create a new Process and Generate a Process with AI) work, since the TemplateSearch component emits these events to the SelectTemplateModal component. Let's sync to take a look at it!
@@ -93,7 +93,7 @@ export default { | |||
return this.$t('Import Process'); | |||
}, | |||
subtitle() { | |||
return this.$t('Import a process from Workfellow PI (.json) to this ProcessMaker environment'); | |||
return this.$t('Import a process from Process Intelligence to this ProcessMaker environment'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the string "Import a process from Process Intelligence to this ProcessMaker environment" to the en.json file
Tickets Solved by this PR:
Solution
Code Review Checklist
ci:next