Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-18762: Added PI Process Import to New Process modal #7319

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

TinCodes
Copy link
Contributor

@TinCodes TinCodes commented Sep 4, 2024

Tickets Solved by this PR:

Solution

  • Created new modal to import PI Processes
  • Deleted the tooltip for Generate Process with AI button on Templates modal

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

return this.$t('Import Process');
},
subtitle() {
return this.$t('Import a process from Workfellow PI (.jpg, .jpeg, .png) to this ProcessMaker environment');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text is not the same as the Figma. Should be:
Import a process from Workfellow PI to this ProcessMaker environment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In sync with Claudia Iriarte and Franz Villaroel this text was to be included here to indicate the file type that the import accepts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file type should be JSON. Also need to update the figma

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we included into SelectTemplateModal? The name is confusing. Maybe we should have our own selectImportPIModal, or change the names to make it reusable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was to keep consistency with how the other 2 buttons (Create a new Process and Generate a Process with AI) work, since the TemplateSearch component emits these events to the SelectTemplateModal component. Let's sync to take a look at it!

@@ -93,7 +93,7 @@ export default {
return this.$t('Import Process');
},
subtitle() {
return this.$t('Import a process from Workfellow PI (.json) to this ProcessMaker environment');
return this.$t('Import a process from Process Intelligence to this ProcessMaker environment');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the string "Import a process from Process Intelligence to this ProcessMaker environment" to the en.json file

@TinCodes TinCodes merged commit 5c8edd7 into epic/FOUR-18761 Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants