Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-8714: Problem with message signals and boundary timer #1649

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented Aug 14, 2023

Issue & Reproduction Steps

Please see https://processmaker.atlassian.net/browse/FOUR-8714

The issue still reproducing after the first fix. The problem was that the node id was correctly generated with the first fix but after modify something in the inspector, that id was lost.
To keep the id, it was added to the timer event definition in the timer boundary event in index.

To Replicate the issue:

  • Import the process of the ticket
  • In the modeler remove the timer boundary event and the message event
  • Add the timer first and then the message event
  • Select the timer and open the inspector, modify the timer control (you need to perform some change in inspector)
  • Select the message boundary event and configure the message
  • Save the process
  • Run a new request
  • Complete the first task, then select retrieve agreement task and complete it. After complete this task you should see only the task After Retrieve

Solution

  • Add generated node id to event definition

Working video

Screen.Recording.2023-08-14.at.10.10.35.mov

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@ryancooley ryancooley merged commit f1a9682 into develop Aug 14, 2023
6 of 9 checks passed
@ryancooley ryancooley deleted the Bugfix/FOUR-8714 branch August 14, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants