-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Loading Issue and Enhancing Parsing for PM Blocks in Process Reloading and Importing #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code maintains the existing approach for adding nodes using the setTimeout function, which enhances the asynchronous handling of PM Block creation while ensuring compatibility with the current implementation.
Ensure that the `createNode` function is awaited before committing the node to the store within the `setNode` method. This change prevents timing issues and guarantees that the node is created and ready before proceeding with the store commit. The `createNode` function was modified to be `async` and `await` the result of node creation before returning. This ensures proper synchronization and prevents unexpected behavior.
eiresendez
approved these changes
Aug 9, 2023
In the setNode function, encapsulate the asynchronous logic related to creating nodes within a separate async function called createNodeAsync. This change enhances code organization and readability. - Moved the creation of nodes and store.commit to createNodeAsync. - Updated the setNode function to call createNodeAsync for asynchronous operations. - Kept setNode as a non-async function for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
This PR effectively resolves a loading issue that occurs during reloading a process when a PM Block is configured. Similarly, it tackles an issue arising when importing a process containing a PM Block.
Previously, when a PM Block was loaded, its node type would erroneously convert to a subprocess, disrupting the configuration of the custom inspector panel for that particular PM Block.
Upon investigation, the problem was traced back to the Modeler's createNode method. The underlying parser in this method was inadvertently defaulting to the
processmaker-modeler-call-activity
instead of the required custom pm-block node.Test Case A:
Test Case B:
Expected behavior:
The PM Block loads the correct node type
Actual behavior:
The PM Block is converted to the subprocess node type
Solution
How to Test
Test the steps above
ci:package-pm-blocks:observation/FOUR-8887
.
Related Tickets & Packages
Code Review Checklist