Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-7834: Changed paper reference to avoid panning errors #1638

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

TinCodes
Copy link
Contributor

Issue & Reproduction Steps

  1. Add a task event
  2. Select the Task
  3. Hold down space
  4. Drag the Paper from top to bottom

Expected behavior:
The selection should not return to the initial state after dragging the container with hold-down space.

Actual behavior:
The selection returns to the initial state as if it were spinning.

Solution

  • Changed the reference of the event listener from Modeler component to paper-container component in order to verify if client left the paper. This made the fix possible.

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@ryancooley ryancooley merged commit 78fa814 into develop Jul 25, 2023
5 checks passed
@ryancooley ryancooley deleted the bugfix/FOUR-7834 branch July 25, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants