Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-9351: Timer control does not show any configuration option #1634

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

danloa
Copy link
Contributor

@danloa danloa commented Jul 20, 2023

Issue & Reproduction Steps

  • Add a timer event to any process
  • Open the inspector

Expected behavior:
Intermediate and boundary timer events should have the "Timing Control" enabled in the Inspector.

Actual behavior:
The timing control can't be opened

Solution

There was a circular reference that was causing the problem. A new file with global constants is used now instead of importing the constant from the inspector component .

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link

@ryancooley ryancooley merged commit 4d6d6d7 into develop Jul 20, 2023
6 checks passed
@ryancooley ryancooley deleted the FOUR-9351 branch July 20, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants