Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-8352 Importing node components async #1618

Closed
wants to merge 3 commits into from
Closed

Conversation

josechirivella
Copy link
Contributor

Issue & Reproduction Steps

Expected behavior:
Components should be imported async when needed. For example.
If we are going to use the "Signal End Event" and put it in the paper, as soon as the user puts the icon in the paper, we will trigger an AJAX Call (done automatically by Webpack) to import that component async to alleviate the final build result, resulting in the final build having the necessary to run modeler and "chunks" to be loaded async when needed.

Actual behavior:
Currently not doing anything async

Solution

How to Test

Test the steps above

  • Open the Chrome Developer Tools, go to the network page
  • Clear the Network page
  • Open the explorer or an already tabbed element in the bottom rail, lets say the "End Signal event", as soon as you put the element in the paper, you should see the file with a relevant name to the Node we just dragged to the paper being called and the image. For Core purposes, the image is the only one being added

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@josechirivella josechirivella self-assigned this Jul 3, 2023
Base automatically changed from summer-2023-3 to develop July 8, 2023 00:10
@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 4.4% 4.44% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@josechirivella josechirivella deleted the FOUR-8352 branch August 3, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant