Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-8764 Added Github Actions #1568

Merged
merged 20 commits into from
Sep 26, 2023
Merged

FOUR-8764 Added Github Actions #1568

merged 20 commits into from
Sep 26, 2023

Conversation

josechirivella
Copy link
Contributor

@josechirivella josechirivella commented May 30, 2023

Issue & Reproduction Steps

Expected behavior:
Our CI/CD pipeline should be able to run in Github Actions

Actual behavior:
Currently running on CircleCi

Solution

How to Test

Test the steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@josechirivella josechirivella self-assigned this May 30, 2023
@pmkerberos
Copy link

QA server was successfully deployed https://ci-7022fe24b7.eng.processmaker.net

@josechirivella josechirivella changed the base branch from summer-2023 to develop June 22, 2023 22:19
@pmkerberos
Copy link

QA server was successfully deployed https://ci-7022fe24b7.eng.processmaker.net

1 similar comment
@pmkerberos
Copy link

QA server was successfully deployed https://ci-7022fe24b7.eng.processmaker.net

@pmkerberos
Copy link

QA server was successfully deployed 2023-06-23T21:08:15+00:00

@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nolanpro nolanpro changed the base branch from develop to next September 14, 2023 23:29
@ana-mauricio
Copy link
Contributor

Locally the e2e tests are working
image
after seeing the errors in CI tests have not been run, It seems there are error in commands that are failing with CI.
image
@josechirivella

@ana-mauricio
Copy link
Contributor

The suits VerifyARecalculationFiresFlowsAreLocatedImproperlyOnTheDiagram && BoundaryEventValidation.cy.js were corrected
@josechirivella @ryancooley

@josechirivella
Copy link
Contributor Author

Yup, that makes Github happy. Thanks @ana-mauricio 🥳

@processmaker-sonarqube
Copy link

@ryancooley ryancooley merged commit 77eb05a into next Sep 26, 2023
12 of 13 checks passed
@ryancooley ryancooley deleted the FOUR-8764 branch September 26, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants