dynamic autoversion server

[rom1504]

will (finally) close #234

[jojomatik]

I can't find any documentation on this feature? Is this still available if so, how can I enable it? @rom1504 maybe?

const wakeUpListener = createServer({
      port: this.port,
      "online-mode": this.properties.onlineMode,
      motd: "",
      maxPlayers: this.properties.maxPlayers,
      favicon: this.favicon,
      version: "any",
    });

This doesn't work for me, fails with:

[1] /usr/games/blockcluster/backend/node_modules/minecraft-protocol/src/createServer.js:33
2022-03-29T15:53:02.240751400Z [1]   if (!mcData) throw new Error(`unsupported protocol version: ${optVersion}`)
2022-03-29T15:53:02.240760400Z [1]                      ^
2022-03-29T15:53:02.240764000Z [1] 
2022-03-29T15:53:02.240767000Z [1] Error: unsupported protocol version: any
2022-03-29T15:53:02.240770000Z [1]     at createServer (/usr/games/blockcluster/backend/node_modules/minecraft-protocol/src/createServer.js:33:22)
2022-03-29T15:53:02.240773500Z [1]     at Server.<anonymous> (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:392:74)
2022-03-29T15:53:02.240777400Z [1]     at Generator.next (<anonymous>)
2022-03-29T15:53:02.240784700Z [1]     at /usr/games/blockcluster/backend/dist/backend/src/components/server.js:44:71
2022-03-29T15:53:02.240788100Z [1]     at new Promise (<anonymous>)
2022-03-29T15:53:02.240790900Z [1]     at __awaiter (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:40:12)
2022-03-29T15:53:02.240804600Z [1]     at Server.waitForConnection (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:389:16)
2022-03-29T15:53:02.240811700Z [1]     at Server.<anonymous> (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:382:24)
2022-03-29T15:53:02.240815100Z [1]     at Generator.next (<anonymous>)
2022-03-29T15:53:02.240817600Z [1]     at fulfilled (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:41:58)

[rom1504]

version: false If you could make a PR to explain this feature in the part of the doc you'd expect it to be, it would be appreciated

…

On Tue, Mar 29, 2022, 17:54 jojomatik ***@***.***> wrote: I can't find any documentation on this feature? Is this still available if so, how can I enable it? @rom1504 <https://github.com/rom1504> maybe? const wakeUpListener = createServer({ port: this.port, "online-mode": this.properties.onlineMode, motd: "", maxPlayers: this.properties.maxPlayers, favicon: this.favicon, version: "any", }); This doesn't work for me, fails with: [1] /usr/games/blockcluster/backend/node_modules/minecraft-protocol/src/createServer.js:33 2022-03-29T15:53:02.240751400Z [1] if (!mcData) throw new Error(`unsupported protocol version: ${optVersion}`) 2022-03-29T15:53:02.240760400Z [1] ^ 2022-03-29T15:53:02.240764000Z [1] 2022-03-29T15:53:02.240767000Z [1] Error: unsupported protocol version: any 2022-03-29T15:53:02.240770000Z [1] at createServer (/usr/games/blockcluster/backend/node_modules/minecraft-protocol/src/createServer.js:33:22) 2022-03-29T15:53:02.240773500Z [1] at Server.<anonymous> (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:392:74) 2022-03-29T15:53:02.240777400Z [1] at Generator.next (<anonymous>) 2022-03-29T15:53:02.240784700Z [1] at /usr/games/blockcluster/backend/dist/backend/src/components/server.js:44:71 2022-03-29T15:53:02.240788100Z [1] at new Promise (<anonymous>) 2022-03-29T15:53:02.240790900Z [1] at __awaiter (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:40:12) 2022-03-29T15:53:02.240804600Z [1] at Server.waitForConnection (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:389:16) 2022-03-29T15:53:02.240811700Z [1] at Server.<anonymous> (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:382:24) 2022-03-29T15:53:02.240815100Z [1] at Generator.next (<anonymous>) 2022-03-29T15:53:02.240817600Z [1] at fulfilled (/usr/games/blockcluster/backend/dist/backend/src/components/server.js:41:58) — Reply to this email directly, view it on GitHub <#508 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437QWBPT5AY5T47KGKQLVCMRU3ANCNFSM4DT7MNHQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jojomatik]

That was fast, thanks :)

const wakeUpListener = createServer({
      port: this.port,
      "online-mode": this.properties.onlineMode,
      motd: "",
      maxPlayers: this.properties.maxPlayers,
      favicon: this.favicon,
      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
      // @ts-ignore
      version: false,
    });

Minecraft still shows an incompatible client, do I misunderstand the feature? I want to disable the warning for every version:

I also don't see how this line would differentiate between undefined and false?

node-minecraft-protocol/src/createServer.js

Line 30 in 9cff34e

const optVersion = version === undefined || version === false ? require('./version').defaultVersion : version

If I find out what's wrong here I can create a PR, sure. Also the types would need to be adjusted. I'm only allowed to use strings.

[rom1504]

I don't think we send all versions as green in the ping indeed, but you can still connect. Indeed undefined might work as well The way this works is we first open a connection with a default version and use that to communicate with the client, then the client give us the version and we switch to that other version. We could probably also answer all good in the ping if the version is false, feel free to look into it, it should be an easy change

…

On Tue, Mar 29, 2022, 18:13 jojomatik ***@***.***> wrote: That was fast, thanks :) const wakeUpListener = createServer({ port: this.port, "online-mode": this.properties.onlineMode, motd: "", maxPlayers: this.properties.maxPlayers, favicon: this.favicon, // eslint-disable-next-line @typescript-eslint/ban-ts-comment // @ts-ignore version: false, }); Minecraft still shows an incompatible client, do I misunderstand the feature? I want to disable the warning for every version: [image: image] <https://user-images.githubusercontent.com/66277921/160656348-337b1028-d3a0-44fc-9217-c737bd6af3db.png> I also don't see how this line would differentiate between undefined and false? https://github.com/PrismarineJS/node-minecraft-protocol/blob/9cff34efc0ac35fb3693a766133ca988ce40b93c/src/createServer.js#L30 If I find out what's wrong here I can create a PR, sure. *Also the types would need to be adjusted. I'm only allowed to use strings.* — Reply to this email directly, view it on GitHub <#508 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437R2MOWGANT57KFRUSDVCMT4JANCNFSM4DT7MNHQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jojomatik]

I've created a PR #976 that should tackle my problems. Feel free to take a look and review :) I hope the versions are assigned correctly