enable cross version with an option in createClient and createServer #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* put parsePacketData in deserializer and createPacketBuffer in serializer * remove packets from the index and expose readPacket instead * load packets when needed in various files * make tests test every supported version static cross version of PrismarineJS#234, fix PrismarineJS#65, fix PrismarineJS#240
|
Ah I forgot to fix https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/examples/proxy/proxy.js#L131 Fixed in 7871ac4 |
also fix a small bug in serializer.js
rom1504
force-pushed
the
static_cross_version
branch
from
a192994
to
3f50a6f
Compare
|
3f50a6f makes it possible to test that cross version functionality easily : just give the version to the proxy
|
Closed
roblabla
added a commit
that referenced
this pull request
Sep 30, 2015
enable cross version with an option in createClient and createServer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static cross version of #234, fix #65, fix #240