Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20.5 #1309

Merged
merged 22 commits into from
Oct 12, 2024
Merged

1.20.5 #1309

merged 22 commits into from
Oct 12, 2024

Conversation

extremeheat
Copy link
Member

@extremeheat extremeheat commented Jul 1, 2024

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

tests seem to fail

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

I updated all deps and rebased

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

current error

gives correct reason for kicking clients when shutting down:
 TypeError: Cannot read properties of undefined (reading 'split')
  at SizeOfCompiler.getField (node_modules/protodef/src/compiler.js:199:23)
  at module.exports.SizeOf.container (node_modules/protodef/src/datatypes/compiler-structures.js:153:31)

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

can reproduce fast with npm run mochaTest -- -g "1.20.5"

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

Updated protodef dep

@rom1504 rom1504 marked this pull request as ready for review October 12, 2024 17:55
@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

kicks clients when invalid credentials:
Uncaught RangeError [ERR_OUT_OF_RANGE]: The value of "offset" is out of range. It must be >= 0 and <= 45. Received -1822185070
at new NodeError (node:internal/errors:405:5)
at boundsError (node:internal/buffer:88:9)
at Buffer.readUInt8 (node:internal/buffer:254:5)
at readVarInt (node_modules/protodef/src/datatypes/utils.js:68:22)
at Splitter._transform (src/transforms/framing.js

For 1.8

Likely due to protodef behavior change

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

I don't really like this arrayWithLengthOffset ; wonder if that could be in protodef

@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

other than that looks fine; merging

@rom1504 rom1504 merged commit 9b029e8 into PrismarineJS:master Oct 12, 2024
25 checks passed
@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

/makerelease

@rom1504bot rom1504bot mentioned this pull request Oct 12, 2024
@rom1504
Copy link
Member

rom1504 commented Oct 12, 2024

still getting

  1. mc-server 1.12.2v
    kicks clients when invalid credentials:
    Uncaught RangeError [ERR_OUT_OF_RANGE]: The value of "offset" is out of range. It must be >= 0 and <= 45. Received -847077210
    at new NodeError (node:internal/errors:405:5)
    at boundsError (node:internal/buffer:88:9)
    at Buffer.readUInt8 (node:internal/buffer:254:5)
    at readVarInt (node_modules/protodef/src/datatypes/utils.js:68:22)
    at Splitter._transform (src/transforms/framing.js:63:30)
    at Transform._write (node_modules/readable-stream/lib/internal/streams/transform.js:153:8)

sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants