-
-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dimensionChange event #3275
base: master
Are you sure you want to change the base?
Conversation
I fixed failing tests locally. Can push later. |
waiting for fix |
/fixlint |
I fixed all linting errors with |
CI is failing, errors are relevant to the change here |
Yes Ill look more into it. It works for me but maybe the github runner needs more time for some stuff. |
and raytrace test failures doesn't seem like timing to me |
const dimensionNames = { | ||
'-1': 'minecraft:nether', | ||
const dimensionIdentifiers = { | ||
'-1': 'minecraft:the_nether', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure its the_nether and not world_nether?
I updated the tests to use the proper assertion methods, so it's easier to see the test mismatches. Could be that the dimension rename is breaking things |
This event is useful as not all emitted respawn events mean a dimension change. This event also emits when a login packet is send as not all login packets cause a spawn event to be emitted.
This pull request also changes some inconsistencies in how dimensions are named. Previously the nether and the end where sometimes refereed to as nether and end instead of the_nether and the_end. Minecraft always named them as the_nether and the_end.
This pull request also fixes a bug where worldName would sometimes not change after a dimension has been changed.