Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements into webservice layout for the huge bots #172

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

sefirosweb
Copy link
Contributor

Hello guys, as I commented in some threads for huge bots it is quite difficult to manage what state it is in and the current interface does not help much

Therefore, I prepared some changes that I think can help the community

Changes:

  • Added bar to resize the panel of behaviors and canvas
    image

  • Navigate within states doing double click on state,

    • if clicked to "start" state, they will up 1 level, will be appears a "up arrow"
      image

    • Only can navigate if the state have sub nested states, will be appears a "down arrow"
      image

  • The tree of nested behavior has been changed, I used a new library "tree.js" to help him to generate the new tree,

    • Added buttons to open all / close all / "auto open" to track the current state active it will open the states automatically
  • Added a example using nested behaviors with typescript

    • I think is important to have a typescript example to show to new users how can make it with better practices
    • For that i needed to add tsconfig.eslint.json to lint the code but ignore it from build
  • Small issues fixed (name of state machine, types)

Preview: https://www.youtube.com/watch?v=-X3EefyDvJg

This ticket can be closed: #115

This file is added to lint also the examples folder but avoiding to build this folder, is for development only
Added tree to new layout also fixed some bugs on states changes and load
Added styles for the tree
This files are only for develop the tree is not necessary
@rom1504
Copy link
Member

rom1504 commented Mar 4, 2023

this is big

@sefirosweb would you like to keep maintaining this package ?

@sefirosweb
Copy link
Contributor Author

Hello @rom1504 , yes there are many changes I tried to make it as small as possible, but with the fact that more data is required and a restructuring of the tree has led me to make this code,

For maintenance I would be happy to help, for me this tool is vital for large bots

@extremeheat extremeheat mentioned this pull request Mar 10, 2023
@kaduvert
Copy link
Contributor

kaduvert commented Sep 3, 2023

I'm just getting into statemachine development and immediately noticed the primitive nature of the web-view, so this seems crazy useful!

sad to see it's stuck, is there no maintainer who can make sense of the changes or what's the problem with this?

@rom1504
Copy link
Member

rom1504 commented Sep 3, 2023

@kaduvert yes, can you try this PR?
If you like it better than master we can merge

@kaduvert
Copy link
Contributor

kaduvert commented Sep 3, 2023

yeah, seems like a good idea.
will start my statemachine endeavours off with this and give feedback once i think i've done enough statemachine stuff to have tested this thoroughly.

@kaduvert
Copy link
Contributor

kaduvert commented Oct 19, 2023

so after my statemachine developments i greatly preferred the experience of this over master, encountered no errors.
haven't looked much at the code but apart from some inconsistent styling / linting it seems to be fine

@sefirosweb
Copy link
Contributor Author

Hey guys, could you please merge the pr? I have more ideas to improve the package but I don't want to mess the code anymore.

@sefirosweb
Copy link
Contributor Author

@rom1504 any news from this topic?

@kaduvert
Copy link
Contributor

@sefirosweb have you seen my PR?
as said, i have no issues with your code, but i noticed some inconsistent styling / linting.
i conveniently created a pull request for you to fix this: sefirosweb#1

if you could merge it i too would fully approve of these changes

@sefirosweb
Copy link
Contributor Author

@sefirosweb have you seen my PR? as said, i have no issues with your code, but i noticed some inconsistent styling / linting. i conveniently created a pull request for you to fix this: sefirosweb#1

if you could merge it i too would fully approve of these changes

I didn't saw 🤣 , done i merge it!

@kaduvert
Copy link
Contributor

kaduvert commented Apr 10, 2024

@rom1504 why don't you merge this or #197 and #198 ?
it's all purely additions improving the project and no breaking changes.

i get that you're scared because there's no maintainer, but there's a small community taking care of this on which you can rely on to steer the project in the right direction.

don't overcomplicate things, if something doesn't work someone will create a pr to fix it. worst case you just revert a breaking pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any idea how to sort the state machines?
3 participants