Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 1.18 and newer chunks in examples #158

Open
TaylorDale opened this issue Dec 5, 2021 · 4 comments
Open

Support 1.18 and newer chunks in examples #158

TaylorDale opened this issue Dec 5, 2021 · 4 comments

Comments

@TaylorDale
Copy link

When I run the chunk decoding example in clientInternal.js on a 1.18 server the chunk provider stays blank. Stepping through the code executing it seems like packet.sub_chunk_count === -1 which causes most of the code in networkDecodeNoCache() to be skipped.

This line is also getting called in ChunkColumn.js which is causing unintended console output, not sure if it is of any relevance:
console.debug('[wp] Read ', extra, 'bytes')

@extremeheat
Copy link
Member

Caves and cliffs update chunks are not currently supported in bedrock-provider

@TaylorDale
Copy link
Author

Got it, cheers 👍

@extremeheat extremeheat reopened this Dec 6, 2021
@extremeheat extremeheat changed the title clientInternal.js Example is broken in 1.18 Support 1.18 chunks in examples Dec 10, 2021
@Bluebotlabz
Copy link

Bluebotlabz commented Oct 16, 2022

Would it work with the updated latest version of bedrock-provider?

(assuming that CI actually worked with it)

@extremeheat extremeheat changed the title Support 1.18 chunks in examples Support 1.18 and newer chunks in examples Oct 16, 2022
@extremeheat
Copy link
Member

The breaking change with bedrock-protocol 3.0 is move of chunk implementation into prismarine-chunk. 1.18.30+ is not supported per issue in pchunk PrismarineJS/prismarine-chunk#182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants