-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GETP-119 feature: 로그인 페이지 구현 #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toothlessdev
reviewed
Apr 3, 2024
이거 관련해서는 어떤식으로 안되는지 보기가 어려워서 대면 스프린트때 직접 보는게 좋을것 같네용 |
toothlessdev
reviewed
Apr 3, 2024
toothlessdev
reviewed
Apr 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해야할일
- 회원가입 Section 컴포넌트 픽셀단위 너비 100% 로 수정
- 회원가입 Section 공통 너비 지정 (500px)
- Footer 컴포넌트 반응형 수정, 리팩토링
- API & Service Layer 추상화
- axios interceptor 사용해서 토큰 로직구현 ?
- React Router Guard 설정 및 Guard 컴포넌트, 토큰관련 훅 구현 ?
- 로그인 회원가입 페이지에 모달 / 버튼 관련 이벤트 핸들러 바인딩
- 비밀번호 및 이메일 인증시 하단 오류 라벨 설정 (상태관리)
앞으로 진행방식 ?
- 코드 알아서 짜오고 핵심로직 설명하는 방식으로 진행 ?
- 코드 짜기 직전 공통된 컴포넌트 분리해보기 (Section 의 너비 또는 Layout 같은거)
추가 논의사항 및 학습이 필요한 사항
- 이미지 처리 (public vs import)
- 반응형 관련 로직 (breakpoint, 반응형 navBar 동작원리 ..)
- Axios Interceptor (이건 나도 많이 안써봐서 배워야함.. 아니면 그냥 api layer 로 추상화 ?)
- 회원가입 Section 공통 너비 지정 (500px) 컴포넌트로 분리 (Ex. AuthSection)
- https://velog.io/@svk5496/%EB%94%94%EC%9E%90%EC%9D%B8-%EC%8B%9C%EC%8A%A4%ED%85%9C-%EB%A7%8C%EB%93%A4%EC%96%B4%EB%B3%B4%EC%9E%90#%EC%BB%AC%EB%9F%AC%EC%8B%9C%EC%8A%A4%ED%85%9C (컬러 시스템 도입 ?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타