Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/b3 d continue pot #319

Closed
wants to merge 12 commits into from
Closed

Feature/b3 d continue pot #319

wants to merge 12 commits into from

Conversation

kudav
Copy link
Collaborator

@kudav kudav commented Dec 5, 2024

This extends the continuegrid functionality to be able to read the existing background profile arrays (if available) and use those for collisions.
If profiles are specified in the input namelist, they take precendent and overwrite the existing ones. This allows the direct import of the background plasma from codes able to output all the quantities on a R-Z grid (like Jorek). It also allows flux-label independent profiles to be used if desired, e.g. for SOL simulations.

Note that currently the ion density is not read in from the original file, which should be adressed before merging.

@kudav kudav requested a review from lazersos December 5, 2024 14:59
@kudav kudav self-assigned this Dec 5, 2024
@kudav kudav added the enhancement New feature or request label Dec 5, 2024
@lazersos
Copy link
Collaborator

lazersos commented Dec 7, 2024

Shouldn't the ability to 'continue' a run only read values from the HDF5 file and not an input namelist?

@kudav
Copy link
Collaborator Author

kudav commented Dec 9, 2024

I think having the option to use profiles controlled by the input namelist adds flexibility and is easy enough to control by having the profile information there or commenting it out. At least in cases where only S and U are included in the continue file, the profile information in the input namelist is necessary. We could have the continue file take precedent over the input profile namelist, but I think the option should be there to change the profiles to whatever is in the namelist.

@lazersos lazersos added this to the Release v.5.5.0 milestone Dec 20, 2024
@lazersos
Copy link
Collaborator

lazersos commented Jan 3, 2025

I'm going to close this and not merge. The general idea behind this feature is to allow grids quantities to be read from a HDF5 file instead of recomputing them. This is fine and make sense to implement. It should be implemented to override all INDATA namelist options, otherwise how the code works becomes WAY too confusing. Additionally, it should be independent of the particle initialization. I think this branch has promise but the way it's implemented is too messy to merge. The changes are:

  • Should only dictate where the background fields come from (no particle stuff).
  • Should fully override whatever is in the input namelist.

@lazersos lazersos closed this Jan 3, 2025
@kudav kudav mentioned this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants