-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParameterPort: handle more getter errors during enumeration #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -374,7 +374,7 @@ | |||
|
|||
from psyneulink._typing import Optional | |||
|
|||
from psyneulink.core.components.component import Component, parameter_keywords | |||
from psyneulink.core.components.component import Component, ComponentsMeta, parameter_keywords |
Check notice
Code scanning / CodeQL
Cyclic import Note
Import of module begins an import cycle.
psyneulink.core.components.component
Error loading related location
Loading
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
Parameter getters may not be valid when called on a Parameter owned by a type. In this case, use the default value to determine if the Parameter can be associated with a ParameterPort. Do not catch exceptions on instantiated classes.
70939a4
to
bb14bb3
Compare
This PR causes the following changes to the html docs (ubuntu-latest-3.11):
See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter getters may not be valid when called on a Parameter owned by a
type. In this case, use the default value to determine if the
Parameter can be associated with a ParameterPort.
Do not catch exceptions on instantiated classes.