-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust print styles for SW4 figures #372
Conversation
Your Render PR Server URL is https://startwords-dev-pr-372.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ckaufr9kms5s73edbno0. |
1b18ec3
to
8f4782a
Compare
@thatbudakguy I've made several adjustments to the figures in your article so they'll display better in the PDF. Wherever I've adjusted sizes, I've kept them proportional - although we may want to adjust a bit more to sizing and spacing based on how the PDF is turning out. (I'll share a test PDF so you can look.) Something is going on with figure 7 that DocRaptor can't handle. Their documentation says they support flexbox but not grid; I thought maybe the nested flexbox was a problem, but I've tried several alternatives that look fine in Firefox print preview but still don't display well in DocRaptor. I just submitted a help request; hopefully we'll hear something soon... @thatbudakguy please review the style changes and the PDF I'll send; if you want to make any adjustments yourself you can use the new script for generating PDFs with DocRaptor. cc @gwijthoff |
@gwijthoff for print, we may want to put table captions at the top instead of the bottom. DocRaptor wraps tables pretty nicely and repeats the table headings, but if the table wraps the caption comes at the bottom of the first page, not at the end. Our default styles are to avoid page breaks within interludes; I've turned this off for a couple of Nick and Gian's figures but we may need a bit more fine-tuning for the flow of content in the PDF of their article. |
update:
|
completed in #372 |
No description provided.