Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust print styles for SW4 figures #372

Merged
merged 16 commits into from
Oct 2, 2023
Merged

Conversation

rlskoeser
Copy link
Contributor

No description provided.

@render
Copy link

render bot commented Sep 28, 2023

@rlskoeser rlskoeser force-pushed the sw4-figures-for-print branch from 1b18ec3 to 8f4782a Compare September 28, 2023 21:34
@rlskoeser
Copy link
Contributor Author

@thatbudakguy I've made several adjustments to the figures in your article so they'll display better in the PDF. Wherever I've adjusted sizes, I've kept them proportional - although we may want to adjust a bit more to sizing and spacing based on how the PDF is turning out. (I'll share a test PDF so you can look.)

Something is going on with figure 7 that DocRaptor can't handle. Their documentation says they support flexbox but not grid; I thought maybe the nested flexbox was a problem, but I've tried several alternatives that look fine in Firefox print preview but still don't display well in DocRaptor. I just submitted a help request; hopefully we'll hear something soon...

@thatbudakguy please review the style changes and the PDF I'll send; if you want to make any adjustments yourself you can use the new script for generating PDFs with DocRaptor.

cc @gwijthoff

@rlskoeser
Copy link
Contributor Author

@gwijthoff for print, we may want to put table captions at the top instead of the bottom. DocRaptor wraps tables pretty nicely and repeats the table headings, but if the table wraps the caption comes at the bottom of the first page, not at the end.

Our default styles are to avoid page breaks within interludes; I've turned this off for a couple of Nick and Gian's figures but we may need a bit more fine-tuning for the flow of content in the PDF of their article.

@rlskoeser
Copy link
Contributor Author

update:

  • I figured out part of the problem, this is CSS and not SCSS so all media queries need to be top-level; I think the browsers tolerate that but DocRaptor does not; figure 7 is looking much better than before now
  • I don't think docraptor supports text-underline-offset; not sure there's anything we can do about that
    — docraptor either doesn't support width: min-content or interprets differently than the browsers; the translation text in figure 7 isn't wrapping to the width of the chinese it accompanies; I have a support request asking for advice on this but we may not hear anything back useful or hear anything in time. If we have to, I suppose we could force it to the width we want for docraptor only....

@gwijthoff gwijthoff merged commit e98bad2 into develop Oct 2, 2023
@gwijthoff gwijthoff deleted the sw4-figures-for-print branch October 2, 2023 15:25
@rlskoeser
Copy link
Contributor Author

completed in #372

@rlskoeser rlskoeser mentioned this pull request Oct 2, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants