Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command for fetching HathiTrust Images #694
Command for fetching HathiTrust Images #694
Changes from 3 commits
24047db
0ff502e
1a64204
9c185e2
a617d94
9106cd5
3776d44
85bc6b1
0f3880a
24c02f9
e18f2ce
51d1591
4df4513
4475a70
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered about a volume-level check to skip an entire volume if the expected number of images are present, but glad to see you have this check.
Check notice on line 165 in ppa/archive/management/commands/hathi_images.py
codefactor.io / CodeFactor
ppa/archive/management/commands/hathi_images.py#L52-L165