Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unpublished scholarship, Goitein index cards in citations (#1502) #1739

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

blms
Copy link
Contributor

@blms blms commented Feb 10, 2025

In this PR

Per #1502:

  • Handle unpublished scholarship citation in transcription/translation viewer
  • Handle grouped unpublished scholarship citations on bibliography pages
  • Handle citations for Goitein unpublished records and index cards with hard-coded date range and formatting

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (1cc58d8) to head (023d8c4).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1739    +/-   ##
=========================================
  Coverage    98.96%   98.97%            
=========================================
  Files          249      249            
  Lines        16283    16417   +134     
=========================================
+ Hits         16115    16249   +134     
  Misses         168      168            

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant