-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdh-web QA deploy playbook #49
Conversation
@thatbudakguy cdh-test-web1 is the server name, not the url — the ones we'd planned to use are documented here: — That reminds me, we'll need to update the allowed hostnames config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and questions, but generally I think this looks good. Was able to pull the latest version of the branch and run the molecule tests successfully.
You tested the new deploy, but might be good to test an old qa deploy also to make sure they still work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates since last time all look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love your deploy user tests!
postgresql looks good also.
@rlskoeser two things still need a decision before merging, I think:
|
@thatbudakguy thanks for identifying what's left and where you need me to weigh in. At this point, I don't want to hold up the migration work any further.
I'd like to put this off. Would you make an issue to add a test? Can we set up a time down the road to pair with Francis on that, or borrow from the example hello world postrges role work he was doing for us?
I don't think it's worth holding up the deploy, since it's pretty minor and not a huge downside (not a heavy cost for backing up an empty database). Should we make an issue to document it? I don't think it's a huge priority, but might be easy to fold in and test once we have the postgres role tested. |
I'm currently able to run the playbook successfully start to finish, but
http://cdh-test-web1.princeton.edu/
times out (I am on VPN). You need to have thecommunity.general
ansible collection installed to run it; see the README for the command to do that. You can run the playbook with:ansible-playbook playbooks/cdh-web_qa.yml
.Tons of changes, since this involved touching virtually every role in some way, although for many of them it was just adding privilege escalation (and maybe a default or two). I also haven't messed with the tests for the
postgresql
role yet. Hoping more eyes on it will help clean up this massive PR.