create a new deploy role #250
Conversation
consolidate the create and close tasks into one role remove the create_deployment and close_deployment role
I am not sure we want to add verification on molecule but this is what it would look like.
Describe dependencies Co-authored-by: Beck Davis <[email protected]> Co-authored-by: Vickie Karasic <[email protected]>
kayiwa
force-pushed
the
i45_deploy_role
branch
from
a305fec to
52ec390
Compare
There was a problem hiding this comment.
Apologies for the delay on reviewing this.
Nick had proposed previously in this issue #45 that these two tasks go into a role named github since the logic is specific to the github api / github deployments. What do you think about that? I think calling the role "deploy" is misleading / ambiguous.
I think the create deployment and close deployment steps need to be separate tasks - right now they are both in the main tasks. Does this allow us to run the create deploy at the beginning of a playbook and then close it at the end of the playbook?
This fail task is littered throughout the other roles (unfortunately) - I'm excited that we're closer to fixing it, but it touches a lot of parts of cdh-ansible. Is there a way to stage it? Can we include the task in the new location for now and start updating roles and playbooks to use the create and fail tasks
| Role Name | ||
| ========= | ||
|
|
||
| Role that deploys CDH applications |
There was a problem hiding this comment.
| Role that deploys CDH applications | |
| Role that creates and updates GitHub deployments when deploying CDH applications to reflect status and environment of application deployments. |
| --- | ||
| galaxy_info: | ||
| role_name: deploy | ||
| company: Princeton University Library |
There was a problem hiding this comment.
CDH ? or both CDH & PUL ?
consolidate the create and close tasks into one role
remove the create_deployment and close_deployment role