Feat ckpt #18
Merged
Feat ckpt #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsja
force-pushed
the
feat-ckpt
branch
2 times, most recently
from
b592ac8
to
1f3ee64
Compare
JohannesHa
reviewed
Sep 30, 2024
| param_offloaded.data.copy_(param_model.data) | ||
|
|
||
| ## the next part is a fix so that each rank save a different dataloader rank. It not efficient because it reads the state two times from disk | ||
| with open(os.path.join(resume_ckpt_path, f"__{world_info.local_rank}_0.pt"), "rb") as f: |
There was a problem hiding this comment.
this prevents us from resuming with a different number of local ranks right? For now since we are just running on 8xH100 nodes it is fine, just good to keep in mind.
There was a problem hiding this comment.
yes indeed, if we need to resume from a different diloco we can easily implement it
JohannesHa
approved these changes
Sep 30, 2024
Jackmin801
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for ckpt ready:
Main different compare to open diloco ckpt is that :
here screenshot with 4 diloco wokrer
here ckpt without diloco