Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate single and multi-user versions of commands #40

Merged
merged 9 commits into from
Aug 9, 2024

Conversation

MatthewL246
Copy link
Member

Resolves #38

Changes:

This changes the regex used to match users in the commands to allow both mentions and user IDs. This is a simple regex that matches a 17 or 18 numbers in a row.

src/commands/kick.ts Outdated Show resolved Hide resolved
@MatthewL246 MatthewL246 marked this pull request as draft August 5, 2024 17:35
@MatthewL246
Copy link
Member Author

Not ready yet, as mods have decided they would prefer separate single and multi-user commands.

@MatthewL246 MatthewL246 changed the base branch from dev to kick-ban-delete-messages August 5, 2024 18:04
@MatthewL246 MatthewL246 changed the title Allow commands to take user IDs Separate single and multi-user versions of commands Aug 5, 2024
@MatthewL246 MatthewL246 marked this pull request as ready for review August 5, 2024 18:22
src/commands/ban.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@wolfendale wolfendale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/commands/ban.ts Outdated Show resolved Hide resolved
src/commands/ban.ts Outdated Show resolved Hide resolved
src/commands/ban.ts Show resolved Hide resolved
src/commands/kick.ts Outdated Show resolved Hide resolved
src/commands/warn.ts Outdated Show resolved Hide resolved
src/util.ts Show resolved Hide resolved
@MatthewL246 MatthewL246 force-pushed the command-user-ids branch 2 times, most recently from a66d4fb to 85f56e1 Compare August 7, 2024 23:13
Base automatically changed from kick-ban-delete-messages to dev August 9, 2024 19:36
Copy link
Member

@jonbarrow jonbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonbarrow jonbarrow merged commit 752d2dd into dev Aug 9, 2024
@MatthewL246 MatthewL246 deleted the command-user-ids branch August 9, 2024 19:52
@MatthewL246 MatthewL246 mentioned this pull request Oct 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants