-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate single and multi-user versions of commands #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfendale
reviewed
Aug 5, 2024
Not ready yet, as mods have decided they would prefer separate single and multi-user commands. |
MatthewL246
changed the title
Allow commands to take user IDs
Separate single and multi-user versions of commands
Aug 5, 2024
MatthewL246
force-pushed
the
command-user-ids
branch
from
August 5, 2024 18:21
4ba40b4
to
a9d8fca
Compare
wolfendale
reviewed
Aug 6, 2024
wolfendale
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jonbarrow
requested changes
Aug 7, 2024
MatthewL246
force-pushed
the
command-user-ids
branch
from
August 7, 2024 22:02
1858be4
to
f2f1bf5
Compare
MatthewL246
force-pushed
the
kick-ban-delete-messages
branch
from
August 7, 2024 22:04
29e6f68
to
1d5b8a4
Compare
MatthewL246
force-pushed
the
command-user-ids
branch
2 times, most recently
from
August 7, 2024 23:13
a66d4fb
to
85f56e1
Compare
jonbarrow
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #38
Changes:
This changes the regex used to match users in the commands to allow both mentions and user IDs. This is a simple regex that matches a 17 or 18 numbers in a row.