Merge pull request #781 from PrestaShopCorp/feat/perf-improvment

Perf improvement

config.xml

@@ -2,7 +2,7 @@
 <module>
   <name>ps_mbo</name>
   <displayName><![CDATA[PrestaShop Marketplace in your Back Office]]></displayName>
-  <version><![CDATA[4.12.0]]></version>
+  <version><![CDATA[4.13.0]]></version>
   <description><![CDATA[Discover the best PrestaShop modules to optimize your online store.]]></description>
   <author><![CDATA[PrestaShop]]></author>
   <tab><![CDATA[administration]]></tab>

ps_mbo.php

@@ -33,11 +33,11 @@
 use PrestaShop\Module\Mbo\Addons\Subscriber\ModuleManagementEventSubscriber;
 use PrestaShop\Module\Mbo\Api\Security\AdminAuthenticationProvider;
 use PrestaShop\Module\Mbo\Helpers\Config;
+use PrestaShop\Module\Mbo\Helpers\ErrorHelper;
 use PrestaShop\PrestaShop\Adapter\SymfonyContainer;
 use PrestaShopBundle\Event\ModuleManagementEvent;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\Dotenv\Dotenv;
-use PrestaShop\Module\Mbo\Helpers\ErrorHelper;
 
 class ps_mbo extends Module
 {
@@ -49,7 +49,7 @@ class ps_mbo extends Module
     /**
      * @var string
      */
-    public const VERSION = '4.12.0';
+    public const VERSION = '4.13.0';
 
     public const CONTROLLERS_WITH_CONNECTION_TOOLBAR = [
         'AdminModulesManage',
@@ -94,7 +94,7 @@ class ps_mbo extends Module
     public function __construct()
     {
         $this->name = 'ps_mbo';
-        $this->version = '4.12.0';
+        $this->version = '4.13.0';
         $this->author = 'PrestaShop';
         $this->tab = 'administration';
         $this->module_key = '6cad5414354fbef755c7df4ef1ab74eb';

src/Controller/Admin/ModuleCatalogController.php

@@ -46,21 +46,6 @@ class ModuleCatalogController extends ModuleAbstractController
      */
     public function indexAction(): Response
     {
-        $moduleUri = __PS_BASE_URI__ . 'modules/ps_mbo/';
-
-        $extraParams = [
-            'cdc_error_templating_url' => $moduleUri . 'views/js/cdc-error-templating.js',
-            'cdc_error_templating_css' => $moduleUri . 'views/css/cdc-error-templating.css',
-        ];
-
-        $cdcJsFile = getenv('MBO_CDC_URL');
-        if (false === $cdcJsFile || !is_string($cdcJsFile) || empty($cdcJsFile)) {
-            $extraParams['cdc_script_not_found'] = true;
-            $extraParams['cdc_error_url'] = $moduleUri . 'views/js/cdc-error.js';
-        } else {
-            $extraParams['cdc_url'] = $cdcJsFile;
-        }
-
         /*********************
          * PrestaShop Account *
          * *******************/
@@ -116,7 +101,7 @@ public function indexAction(): Response
                     'You do not have permission to add this.',
                     'Admin.Notifications.Error'
                 ),
-            ] + $extraParams
+            ]
         );
     }
 

src/Traits/Hooks/UseActionAdminControllerSetMedia.php

@@ -116,7 +116,8 @@ private function loadCdcMedia(): void
         }
         if (
             !Tab::mayDisplayRecommendedModules($controllerName) &&
-            !in_array($controllerName, self::CONTROLLERS_WITH_CDC_SCRIPT)
+            !in_array($controllerName, self::CONTROLLERS_WITH_CDC_SCRIPT) &&
+            $controllerName !== 'AdminPsMboModule'
         ) {
             return;
         }