Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use feature value position for ordering #1083

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

ks129
Copy link

@ks129 ks129 commented Sep 27, 2024

Questions Answers
Description? Use feature value new position field for ordering of feature values. Part of PrestaShop/PrestaShop#37042
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? part of PrestaShop/PrestaShop#35499 and PrestaShop/PrestaShop#32267
How to test? If used together with parent PR, it should show feature values in faceted search in the order provided in BO.

Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ks129 I like this, but please keep the option to sort the features alphabetically.

I have only one client that sells clothes.

For all other clients, it will be a pain in the ass when they would have to sort the features manually. Alphabetical sorting is OK for most of the stores.

@ps-jarvis ps-jarvis added the waiting for author Waiting for author's feedback label Sep 30, 2024
@ps-jarvis
Copy link

This pull request seems to contain new translation strings. I have summarized them below to ease up review:

  • Modules.Facetedsearch.Admin
    • Use position for feature values ordering

(Note: this is an automated message, but answering it will reach a real human)

@ks129 ks129 requested a review from Hlavtox October 2, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Waiting for author's feedback waiting for wording
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

3 participants