Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Twitter logos by X #643

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Replace Twitter logos by X #643

merged 1 commit into from
Jul 1, 2024

Conversation

Klemart3D
Copy link
Contributor

Questions Answers
Description? Replace Twitter logo by X
Type? Improvement
BC breaks? no
Deprecations? no
Fixed ticket? PrestaShop/PrestaShop#36470
Sponsor company Klemart3D
How to test? After compilation, ps_sharebuttons block must display X logo in place of Twitter: X

@florine2623 florine2623 self-assigned this Jul 1, 2024
florine2623
florine2623 approved these changes Jul 1, 2024
View reviewed changes
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Klemart3D ,

LGTM ✅

Screen.Recording.2024-07-01.at.17.10.13.mov

@boherm boherm merged commit 31b651a into PrestaShop:develop Jul 1, 2024
6 checks passed
@boherm
Copy link
Member

boherm commented Jul 1, 2024

Thanks @Klemart3D!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicosomb nicosomb nicosomb approved these changes

@florine2623 florine2623 florine2623 approved these changes

@boherm boherm boherm approved these changes

Assignees

@florine2623 florine2623

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Klemart3D @boherm @nicosomb @florine2623 @ps-jarvis