Product page : can't change the quantity via input, the quantity 1 is always displayed #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosomb
approved these changes
Jul 1, 2024
florine2623
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Hello @boherm ,
Thanks for the PR !
Tested with/out debug mode.
Tested with minimum quantity ≠ 1.
Tested with Combination products.
Tested with backspace key, arrows, and select input to change quantity.
LGTM ✅
Screen.Recording.2024-07-01.at.17.29.05.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact, we need to check quantity min not when we are typing but only on change. If we do this check on keyup or keydown, we can't type a
backspaceto empty the input before typing our new value, and also, if the min quantity of the product is set at 5, if we want to type10after abackspace, we force to5when the1key is typed and before the0of10.