-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: issue-611 #626
Merged
Merged
Fix: issue-611 #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tblivet
commented
May 17, 2024
Questions | Answers |
---|---|
Description? | Fix #611 |
Type? | bug fix |
BC breaks? | no |
Deprecations? | |
Fixed ticket? | Fix #611 |
Sponsor company | @PrestaShopCorp |
How to test? | You can follow the steps described in the issue |
nicosomb
previously approved these changes
May 17, 2024
Hlavtox
previously approved these changes
May 20, 2024
ga-devfront
previously approved these changes
May 20, 2024
tblivet
dismissed stale reviews from ga-devfront, Hlavtox, and nicosomb
via
May 20, 2024 16:19
1950578
Hi, I noticed that there were two blocks intended to display the link, one for Desktop and one for Mobile, so I've updated the PR. |
nicosomb
approved these changes
May 20, 2024
boherm
approved these changes
May 21, 2024
florine2623
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.