Fix: when you edit the product qty to zero, the product won't be removed from the cart #542

tblivet · 2023-08-10T17:21:59Z

Questions	Answers
Description?	Correct the issue 536
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #536
Sponsor company	@PrestaShopCorp
How to test?	You can refer to the issue

matks

Looks good to me 👍

ping @ga-devfront for 2nd opinion

SharakPL · 2023-08-15T08:42:02Z

IMO it would be better to simply disallow changing quantity to 0. This can be done by mistake and then the product would have to be searched again. If a user wants to remove the product from the cart then the Remove button should be clicked.

Hlavtox · 2023-08-15T08:51:55Z

@SharakPL That was how it was before. It should throw an error message "Minimal quantity for sale is 1".

Also, it's a bit incosistent. What does it do if minimum quantity for sale is higher than 1? 🤔

I am a bit torn apart for the expected behavior here.

sallemiines

Hello @tblivet

Thanx for the PR ! LGTM QA ✔️

develop_prs.mp4

Thank you 🚀

SharakPL · 2023-08-15T15:36:51Z

@sallemiines could you please check again with product that has minimum order quantity higher than 1? It doesn't look like it's covered.

FabienPapet

blocking as we need to check before merge

MhiriFaten

Merging is blocked, I will remove the waiting for QA label until the changes requests are resolved.

kpodemski

I wanted to agree with @Hlavtox and @SharakPL, but I've just tested it on PS 8.1 with Classic, and it works like this:

The behavior should be as follows:

If you change from 1 to 0 using arrows, the product is deleted.
If you change from 1 to 0 using the input value, the product is deleted.
If you have a product with a minimal quantity set to 2 and you change it to 1, you have an error.

Why does it work in Classic, and it doesn't work with Hummingbird?
What's the difference between Classic and Humminbird?

If you have 1 unit in your shopping cart and you change it to 0 (either by using arrows or input), the request goes to delete action. In Hummingbird, it always goes to the update action, which is wrong.

This PR almost fixes the issue but there's a problem with getting a minimal quantity which could be different than 1.

kpodemski · 2023-08-22T09:43:33Z

@tblivet Related function in Classic is inside:

themes/classic/_dev/js/cart.js in updateProductQuantityInCart function.

if (targetValue === '0') {
      $target.closest('.product-line-actions').find('[data-link-action="delete-from-cart"]').click();
    } else {
      $target.attr('value', targetValue);
      sendUpdateQuantityInCartRequest(updateQuantityInCartUrl, getRequestData(qty), $target);
    }

It looks that instead of checking minimal quantity you should only check whether the target value is equal to 0.

SharakPL · 2023-08-23T15:55:00Z

Is there a place for improvements or does it have to be done like in Classic?

kpodemski · 2023-08-23T16:01:48Z

@SharakPL what would be an improvement in your opinion?

SharakPL · 2023-08-23T16:14:49Z

To be more clear on what each action does. Decreasing the amount shouldn't delete the product from the cart.
If the requested amount is lower than the minimum required for order then it should throw an error:

The minimum amount required for order of this product is X. If you want to remove the product completely from your cart then use the Remove button

Or at least change [ - ] to [ X ] or [ trash_icon ] to indicate that next use of this button will remove it completely instead of just decreasing the amount. Especially useful if the minimum required amount is higher than 1.

kpodemski · 2023-08-23T16:22:16Z

The one improvement I see in this change is that if one makes a mistake and changes the value below 1, it could save the cart. I've checked a few stores, and when there are arrows, changing below 1 is forbidden. There's no request, which could also be a good thing.

Something to be decided by @PrestaShop/product-council :)

To summarize:

If you change the value below 1, it should inform about minimal quantity or doesn't do anything.

SharakPL · 2023-08-24T07:37:10Z

I've checked a few stores, and when there are arrows, changing below 0 is forbidden.

Did you mean "below 1"?

kpodemski · 2023-08-24T07:39:25Z

@SharakPL yes, I edited the message

RosaBenouamer · 2023-08-24T08:08:43Z

Hello,
On Amazon :

You have a text next to 0 which precise that by clicking on 0 you will suppress the article

I find it's quite a good idea.
Concerning the case where you have a minimum of quantity to order to validate it. I imagine for instance, if you have to order minimum of 30. The list in the arrow will be 0 to let to suppress then directly 30,31,32...

Hlavtox · 2023-08-24T08:16:13Z

@RosaBenouamer There needs to be a number input, dropdown for selecting count is not good UX. :-)

jolelievre · 2023-08-31T08:49:59Z

src/js/pages/cart.ts

+        const targetItem = eventTarget.closest('.cart__item');
+        const targetValue = targetItem?.querySelector('.js-cart-line-product-quantity') as HTMLElement | null;
+
+        if (targetValue && targetValue.getAttribute('value') === '1' && targetValue.getAttribute('min') === '1') {


Be careful the min quantity can also be 0 which should be handled like 1, meaning the feature is disabled there is no minimum
Except that I think the original behaviour from classic is consistent and should be used as a base as it's a common way to handle this in many e-commerce shops

tldr; let's stay iso functional

Ah and one other comment you seem to be listening to the click event, so only the arrows clicking but the value can also be edited via keyboard, so you should either listen to the keydown event as well or maybe easier simply the change event?

Unless you need to listen to the specific event to cancel it when the value is not the minimum one?

tblivet · 2023-08-31T16:40:00Z

Hello 👋 With @ga-devfront we have update the PR we now have this behavior :

When we click on decrement to go from 1 to 0 -> product is deleted
When we click on decrement to go from 5 to 4 when product has minimum qty of 5 -> product is not deleted error message appear and qty remain the same.
When we change the quantity manually (without + or - ) to 0 -> product is deleted
When we change the quantity manually (without + or - ) to 0 and the product have minimum qty -> product is not deleted error message appear and qty remain the same.

ga-devfront · 2023-09-05T12:37:38Z

No response from the people who blocked the PR, additions were made and the behavior seems to be the most common to web standards:
Impossible to go below the minimum orderable unless it is 0 in which case the product is deleted.
I pass the PR to Waiting for QA

davidglezz · 2023-09-06T11:34:18Z

src/js/pages/cart.ts

+      if (targetValue) {
+        if (eventTarget.classList.contains('js-increment-button')) {
+          if (targetValue.dataset.mode === 'confirmation' && Number(targetValue.value) < 1) {
+            if (removeButton) {
+              removeButton.click();
+            }
+          }
+        }
+
+        if (eventTarget.classList.contains('js-decrement-button')) {
+          if (targetValue.getAttribute('value') === '1' && targetValue.getAttribute('min') === '1') {
+            if (removeButton) {
+              removeButton.click();
+            }
+          }
+        }
+      }


Suggested change

if (targetValue) {

if (eventTarget.classList.contains('js-increment-button')) {

if (targetValue.dataset.mode === 'confirmation' && Number(targetValue.value) < 1) {

if (removeButton) {

removeButton.click();

}

}

}

if (eventTarget.classList.contains('js-decrement-button')) {

if (targetValue.getAttribute('value') === '1' && targetValue.getAttribute('min') === '1') {

if (removeButton) {

removeButton.click();

}

}

}

}

if (targetValue && removeButton) {

if (eventTarget.classList.contains('js-increment-button')) {

if (targetValue.dataset.mode === 'confirmation' && Number(targetValue.value) < 1) {

removeButton.click();

}

}

if (eventTarget.classList.contains('js-decrement-button')) {

if (targetValue.getAttribute('value') === '1' && targetValue.getAttribute('min') === '1') {

removeButton.click();

}

}

}

The code can be simplified, the first if avoid 2 ifs.

All could go in an single if but I wouldn't know how readable it would be.

djoelleuch

Hello @tblivet ,
LGTM ,
If you change from 1 to 0 using arrows, the product is deleted. ✔️
If you change from 1 to 0 using the input value, the product is deleted. ✔️
If you have a product with a minimal quantity set to 2 and you change it to 1, you have an error.
✔️
[but i think that the error message disappear too fast ]

Dashboard.Prestashopdev.mp4

It's QA approved ✔️
thank you !

I'm dismissing Fabien. His alert was listened

fix: delete cart product when click on minus

482bc85

matks changed the title ~~fix: when you edit the product qty to zero, the product won't be removed from the cart~~ Fix: when you edit the product qty to zero, the product won't be removed from the cart Aug 14, 2023

matks previously approved these changes Aug 14, 2023

View reviewed changes

ps-jarvis added the Waiting for QA label Aug 14, 2023

sallemiines self-assigned this Aug 15, 2023

This comment was marked as outdated.

Sign in to view

sallemiines added QA ✔️ and removed Waiting for QA labels Aug 15, 2023

hibatallahAouadni added Waiting for QA and removed QA ✔️ labels Aug 15, 2023

hibatallahAouadni requested a review from sallemiines August 15, 2023 15:04

sallemiines previously approved these changes Aug 15, 2023

View reviewed changes

sallemiines added QA ✔️ and removed Waiting for QA labels Aug 15, 2023

FabienPapet previously requested changes Aug 15, 2023

View reviewed changes

nicosomb added this to the Beta milestone Aug 15, 2023

nicosomb added Waiting for QA and removed QA ✔️ labels Aug 21, 2023

paulnoelcholot assigned paulnoelcholot and unassigned sallemiines Aug 21, 2023

MhiriFaten reviewed Aug 21, 2023

View reviewed changes

MhiriFaten added Waiting for author and removed Waiting for QA labels Aug 21, 2023

paulnoelcholot removed their assignment Aug 22, 2023

kpodemski previously requested changes Aug 22, 2023

View reviewed changes

jolelievre reviewed Aug 31, 2023

View reviewed changes

fix: input change on cart qty below 1

fd55b60

tblivet dismissed stale reviews from sallemiines and matks via fd55b60 August 31, 2023 16:07

tblivet added 2 commits August 31, 2023 18:09

refacto: remove console log

a4bd5ce

chore: lint

fd439cc

tblivet requested review from kpodemski, FabienPapet, jolelievre and matks September 1, 2023 07:29

ga-devfront added Waiting for QA and removed Waiting for author labels Sep 5, 2023

ga-devfront approved these changes Sep 5, 2023

View reviewed changes

davidglezz reviewed Sep 6, 2023

View reviewed changes

djoelleuch self-assigned this Sep 6, 2023

djoelleuch approved these changes Sep 6, 2023

View reviewed changes

djoelleuch added QA ✔️ and removed Waiting for QA labels Sep 6, 2023

nicosomb merged commit e669588 into PrestaShop:develop Sep 7, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: when you edit the product qty to zero, the product won't be removed from the cart #542

Fix: when you edit the product qty to zero, the product won't be removed from the cart #542

tblivet commented Aug 10, 2023

matks left a comment

SharakPL commented Aug 15, 2023 •

edited

Loading

Hlavtox commented Aug 15, 2023

This comment was marked as outdated.

sallemiines left a comment

SharakPL commented Aug 15, 2023

FabienPapet left a comment •

edited

Loading

MhiriFaten left a comment

kpodemski left a comment

kpodemski commented Aug 22, 2023

SharakPL commented Aug 23, 2023

kpodemski commented Aug 23, 2023

SharakPL commented Aug 23, 2023 •

edited

Loading

kpodemski commented Aug 23, 2023 •

edited

Loading

SharakPL commented Aug 24, 2023

kpodemski commented Aug 24, 2023

RosaBenouamer commented Aug 24, 2023

Hlavtox commented Aug 24, 2023

jolelievre Aug 31, 2023

jolelievre Aug 31, 2023

tblivet commented Aug 31, 2023

ga-devfront commented Sep 5, 2023

davidglezz Sep 6, 2023 •

edited

Loading

djoelleuch left a comment

Fix: when you edit the product qty to zero, the product won't be removed from the cart #542

Fix: when you edit the product qty to zero, the product won't be removed from the cart #542

Conversation

tblivet commented Aug 10, 2023

matks left a comment

Choose a reason for hiding this comment

SharakPL commented Aug 15, 2023 • edited Loading

Hlavtox commented Aug 15, 2023

This comment was marked as outdated.

sallemiines left a comment

Choose a reason for hiding this comment

SharakPL commented Aug 15, 2023

FabienPapet left a comment • edited Loading

Choose a reason for hiding this comment

MhiriFaten left a comment

Choose a reason for hiding this comment

kpodemski left a comment

Choose a reason for hiding this comment

kpodemski commented Aug 22, 2023

SharakPL commented Aug 23, 2023

kpodemski commented Aug 23, 2023

SharakPL commented Aug 23, 2023 • edited Loading

kpodemski commented Aug 23, 2023 • edited Loading

SharakPL commented Aug 24, 2023

kpodemski commented Aug 24, 2023

RosaBenouamer commented Aug 24, 2023

Hlavtox commented Aug 24, 2023

jolelievre Aug 31, 2023

Choose a reason for hiding this comment

jolelievre Aug 31, 2023

Choose a reason for hiding this comment

tblivet commented Aug 31, 2023

ga-devfront commented Sep 5, 2023

davidglezz Sep 6, 2023 • edited Loading

Choose a reason for hiding this comment

djoelleuch left a comment

Choose a reason for hiding this comment

SharakPL commented Aug 15, 2023 •

edited

Loading

FabienPapet left a comment •

edited

Loading

SharakPL commented Aug 23, 2023 •

edited

Loading

kpodemski commented Aug 23, 2023 •

edited

Loading

davidglezz Sep 6, 2023 •

edited

Loading