Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit payment option to work with ps_checkout #533

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented Jul 28, 2023

Questions Answers
Description? Payment option display has been edited to make ps_checkout display properly
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? --
Sponsor company @PrestaShopCorp
How to test? Check if payment methods are correctly displayed. Not easy to test because the shop must have ps_checkout configure, but this should render the payment option like in the screen below : top -> before & bottom -> after ![image](https://github.com/PrestaShop/hummingbird/assets/110676325/519e3161-c91a-465c-9f9b-9e6a7bbeefe4)

Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ps_checkout is not a native module, this is why the fix shouldn't be there

if changes in .tpl are valid for other payment methods, it's ok, but CSS rules shouldn't be part of Hummingbird

you can easily add it to your version of the theme, or contribute to ps_checkout to display correctly if the theme is Hummingbird

@@ -0,0 +1,10 @@
.payment__option {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be inside core of Hummingbird but rather inside your theme or ps_checkout module :)

@tblivet
Copy link
Contributor Author

tblivet commented Jul 31, 2023

Hello @kpodemski !
I have removed the CSS related to "ps_checkout".
I think the template is still relevant because it improves the display of payment option in case we have an image.

Copy link

@aniszr aniszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet
I tested your PR, the checkout options are well displayed, LGTM ✔️
QA ✔️

See attached screenshot :
image

Thanks!

@aniszr aniszr self-assigned this Aug 4, 2023
@nicosomb nicosomb merged commit 34fe1bc into PrestaShop:develop Aug 4, 2023
6 checks passed
@nicosomb nicosomb added this to the Beta milestone Aug 4, 2023
@nicosomb
Copy link
Contributor

nicosomb commented Aug 4, 2023

Thank you @tblivet !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants