[NEW-UI] optimise frontend #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ga-devfront
commented
Oct 30, 2024
ga-devfront
commented
| Questions | Answers |
|---|---|
| Description? | Refactor TS and add JS doc |
| Type? | improvement / refactor |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | |
| Sponsor company | @PrestaShopCorp |
| How to test? | Try if nothing change on new UI |
ga-devfront
force-pushed
the
feat/optimise-frontend
branch
from
c9149ce to
e5bfae8
Compare
Quetzacoalt91
previously approved these changes
Nov 4, 2024
Quetzacoalt91
approved these changes
Nov 4, 2024
ga-devfront
force-pushed
the
feat/optimise-frontend
branch
from
db814be to
67f4924
Compare
|
AureRita
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Hi @ga-devfront
Thank you for your PR, I tested it and it seems to works as you can see :
Tested from :
1.7.8.8 to 8.2
8.0.4 to 8.2
8.2 to 9.0.0
8.0.5 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.