-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: start new front #861
Merged
ga-devfront
merged 27 commits into
PrestaShop:dev
from
ga-devfront:feat/start-new-front
Sep 10, 2024
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
36d046e
feat: setup dev folder
ga-devfront 303127d
feat: setup controller to handle assets generated by vite in dev or p…
ga-devfront 6d9fd6e
fix: vite configuration for dev and prod
ga-devfront a3a5841
fix: remove unused function
ga-devfront fc55700
fix: add package.json
ga-devfront 7415e74
fix: dotenv
ga-devfront 45f5c7d
fix: cs fixer and php stan issues
ga-devfront 63c23ec
fix: 5.6 syntax check
ga-devfront fce38b6
feat: add CI for build and check lint JS
ga-devfront 0edf261
fix: eslint config
ga-devfront 9860247
feat: update ci and readme
ga-devfront 8c26830
feat: clean package json with unnecessary packages
ga-devfront 81bb23c
fix: vite.config.ts with ts error
ga-devfront 720f2df
feat: add style and stylelint
ga-devfront da5f475
feat: add templates
ga-devfront cff77f4
feat: add index.php
ga-devfront 146f5d2
feat: add storybook
ga-devfront 799545f
feat: add images
ga-devfront 77f808b
feat: remove test javascript
ga-devfront a8bf6be
feat: add compilation of _dev styles to storybook
ga-devfront 9981e0e
feat: move scss and ts to src and rename folders
ga-devfront f6b9953
fix: review code
ga-devfront 95028ac
fix: reformat twig templates
ga-devfront 5c389ac
fix: workflow steps name
ga-devfront c9618ed
fix: review issues
ga-devfront 285e58b
feat: add readme commands for lint and test front and back
ga-devfront 156a717
feat: add instruction for php stan installation
ga-devfront File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
AUTOUPGRADE_DEV_WATCH_MODE=0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,10 +20,22 @@ jobs: | |
- name: Install composer dependencies | ||
run: composer install --ansi --prefer-dist --no-interaction --no-progress --no-dev | ||
|
||
- name: Setup node | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20.x' | ||
|
||
- name: Install and build npm dependencies | ||
run: | ||
npm install --prefix ./_dev | ||
npm run vite:build --prefix ./_dev | ||
|
||
- name: Clean-up project | ||
uses: PrestaShopCorp/[email protected] | ||
with: | ||
paths: storybook | ||
paths: | ||
- storybook | ||
- _dev | ||
|
||
- name: Create & upload artifact | ||
uses: actions/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: JS tests | ||
on: [push, pull_request] | ||
concurrency: | ||
group: ${{ github.event_name }}-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
cancel-in-progress: true | ||
jobs: | ||
js-linter: | ||
name: JS linter syntax check | ||
runs-on: unbuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
|
||
- name: Setup node | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20.x' | ||
|
||
- name: Install npm dependencies | ||
run: | ||
npm install --prefix ./_dev | ||
|
||
- name: Launch typescript linter | ||
run: | ||
npm run lint --prefix ./_dev | ||
|
||
- name: Launch scss linter | ||
run: | ||
npm run lint-scss --prefix ./_dev |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
nbproject | ||
|
||
vendor/ | ||
node_modules/ | ||
/config_*.xml | ||
.php_cs.cache | ||
.idea | ||
.env | ||
|
||
## QA Nightly | ||
/artifacts | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"singleQuote": true, | ||
"trailingComma": "none", | ||
"printWidth": 100, | ||
"tabWidth": 2, | ||
"overrides": [ | ||
{ | ||
"files": "*.scss", | ||
"options": { | ||
"printWidth": 100, | ||
"tabWidth": 2, | ||
"useTabs": false, | ||
"singleQuote": false, | ||
"bracketSpacing": true, | ||
"parser": "scss" | ||
} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
module.exports = { | ||
extends: '@prestashopcorp/stylelint-config', | ||
rules: { | ||
'comment-empty-line-before': null, | ||
'no-unknown-animations': null, | ||
'scss/at-import-no-partial-leading-underscore': null | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// @ts-check | ||
|
||
import eslint from '@eslint/js'; | ||
import tseslintPlugin from '@typescript-eslint/eslint-plugin'; | ||
import tseslintParser from '@typescript-eslint/parser'; | ||
import eslintPluginPrettier from 'eslint-plugin-prettier'; | ||
import globals from 'globals'; | ||
|
||
export default [ | ||
eslint.configs.recommended, | ||
{ | ||
files: ['**/*.js'], | ||
languageOptions: { | ||
ecmaVersion: 2022, | ||
sourceType: 'module', | ||
globals: { | ||
...globals.browser, | ||
...globals.node | ||
} | ||
} | ||
}, | ||
{ | ||
files: ['**/*.ts', '**/*.tsx'], | ||
languageOptions: { | ||
ecmaVersion: 2022, | ||
sourceType: 'module', | ||
globals: { | ||
...globals.browser, | ||
...globals.node | ||
}, | ||
parser: tseslintParser, | ||
parserOptions: { | ||
project: './tsconfig.json' | ||
} | ||
}, | ||
plugins: { | ||
'@typescript-eslint': tseslintPlugin | ||
}, | ||
rules: { | ||
...tseslintPlugin.configs.recommended.rules | ||
} | ||
}, | ||
{ | ||
plugins: { | ||
prettier: eslintPluginPrettier | ||
}, | ||
rules: { | ||
...eslintPluginPrettier.configs.recommended.rules | ||
} | ||
} | ||
]; |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be interesting to list other commands that can help, how to linter, build... Also explain hot-reload