Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build of module #810

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix build of module #810

merged 2 commits into from
Jul 17, 2024

Conversation

Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Jul 17, 2024 •
edited
Loading

Questions Answers
Description? The creation of module zip is failing for several reasons. I.e because we run a dev dependency after a composer install with production only deps.
Type? bug fix
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company /
How to test? Test releases must succeed, see https://github.com/Quetzacoalt91/autoupgrade/releases/tag/v6.0.0-test.2

@Quetzacoalt91 Quetzacoalt91 self-assigned this Jul 17, 2024
@Quetzacoalt91 Quetzacoalt91 marked this pull request as ready for review July 17, 2024 14:40
@Quetzacoalt91 Quetzacoalt91 added this to the 6.0.0 milestone Jul 17, 2024
@Quetzacoalt91 Quetzacoalt91 changed the title Remove quality check step from build workflow Fix build of module Jul 17, 2024
@Quetzacoalt91 Quetzacoalt91 merged commit ad67877 into PrestaShop:dev Jul 17, 2024
34 checks passed
@Quetzacoalt91 Quetzacoalt91 deleted the remove-CI-check-from-build-workflow branch July 17, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ga-devfront ga-devfront ga-devfront approved these changes

Assignees

@Quetzacoalt91 Quetzacoalt91

Labels
None yet
Projects
PR Dashboard
Archived in project
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Quetzacoalt91 @ga-devfront @ps-jarvis