Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release process in GH workflows #788

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

M0rgan01
Copy link
Contributor

Questions Answers
Description? Improve release process in GH workflows
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? -

@M0rgan01 M0rgan01 force-pushed the improve-release-process branch from eb6749c to 4ffb2d9 Compare July 11, 2024 14:16
@M0rgan01 M0rgan01 added this to the 6.0.0 milestone Jul 11, 2024
@M0rgan01 M0rgan01 marked this pull request as draft July 11, 2024 14:59
@M0rgan01 M0rgan01 force-pushed the improve-release-process branch from 4ffb2d9 to 6982ca0 Compare July 11, 2024 15:43
@M0rgan01 M0rgan01 marked this pull request as ready for review July 11, 2024 15:43
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of relying on variables whenever possible for re-usability.

.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
@M0rgan01 M0rgan01 force-pushed the improve-release-process branch from 6982ca0 to a6bc1d1 Compare July 12, 2024 07:49
@Quetzacoalt91
Copy link
Member

Before merging, we need to remove the autoupgrade folder from https://github.com/PrestaShop/PrestaShop-modules/

@M0rgan01
Copy link
Contributor Author

@Quetzacoalt91 Quetzacoalt91 merged commit 27820ec into PrestaShop:dev Jul 15, 2024
34 checks passed
@Quetzacoalt91 Quetzacoalt91 deleted the improve-release-process branch July 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants