-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook integration #761
Conversation
87955f2
to
e843893
Compare
54f9bd5
to
1c52c55
Compare
storybook/README.md
Outdated
@@ -0,0 +1,104 @@ | |||
# Storybook overview | |||
|
|||
This mini-project provides an overview of the different components of the interface of the "Upgrade assistant" module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mini-project provides an overview of the different components of the interface of the "Upgrade assistant" module | |
This mini-project provides an overview of the different components of the interface of the "Update assistant" module |
Waiting for a decision to take about the themes included in the autoupgrade project or not. |
Unblocked: This PR will have the themes assets removed from the commits list to avoid pushing to much development stuff in the history, then another PR will be created later to add them via a NPM dependency. |
df0a67e
to
240bde7
Compare
Yes, templates extensions have changed |
@@ -202,7 +202,7 @@ | |||
{% endfor %} | |||
</ul> | |||
</td> | |||
<td>{{ icons.nok }}</td> | |||
<td>{{ icons.nok(psBaseUri) }}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like that we have to send the variable psBaseUri
to each call, is there any other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very comfortable with this approach too :/ another solution is to use the _context variable, (_context.psBaseUri) but this is worse for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as we expected
Tested from :
1.7.8.8 to 8.1.6
8.0.5 to 8.1.6
8.1.5 to 8.1.6
8.1.6 to 9.0.0
8.1.5 to 9.0.0
8.0.5 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
BC breaks
To-do
trans
modifier, inclusion of other template and aliasesTo-do (later)
Capture.video.du.08-07-2024.14.24.12.webm