Add new hooks in sql upgrade statement #1168
Conversation
tleon
commented
Feb 11, 2025
tleon
commented
| Questions | Answers |
|---|---|
| Description? | Added the new hooks from 9.0.x to the sql upgrade statement |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #37163 |
| Sponsor company | PrestaShop SA |
| How to test? | CI green |
There was a problem hiding this comment.
@tleon I think you should update the part that @jolelievre added in his previous PR, because, for example, the part deleting the hooks is identical
tleon
force-pushed
the
add-new-hooks-in-sql-statement
branch
from
c700bd9 to
3a0027e
Compare
|
| (NULL, 'dashboardData', '', '', '1'), | ||
| (NULL, 'actionPasswordRenew', '', '', '1'), | ||
| (NULL, 'actionDownloadAttachment', '', '', '1'), | ||
| (NULL, 'fooHook', '', '', '1'), |
There was a problem hiding this comment.
Is there really a hook with this name in production?
There was a problem hiding this comment.
There was a problem hiding this comment.
yes, this is the same problem as with the generated docs, some of the hooks should be excluded, I added more comments on this PR
There was a problem hiding this comment.
In the end i don't know anymore if this command is a good idea i'm a but tired of all of this :/
There was a problem hiding this comment.
it is a good idea and it works great, the most important remaining thing is to have block-list of hooks available, so you don't generate them, hooks from tests directory, and hooks that are deprecated :)
|
How will users be able to use hooks without them having a description ? |
