Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW-UI] Dialog tempered files #1090

Merged
merged 10 commits into from
Dec 20, 2024
Merged

[NEW-UI] Dialog tempered files #1090

merged 10 commits into from
Dec 20, 2024

Conversation

ga-devfront
Copy link
Contributor

Questions Answers
Description? Adding dialog for tempered files inside requirements
Type? new feature
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Sponsor company @PrestaShopCorp
How to test? Delete or modifies some theme/core files and click on "See the list of alterations." link. (version choice page on new UI)

@ga-devfront ga-devfront added this to the 7.0.0 milestone Dec 17, 2024
@ga-devfront ga-devfront changed the title [NEW-ui] Dialog tempered files [NEW-UI] Dialog tempered files Dec 17, 2024
@ga-devfront ga-devfront marked this pull request as ready for review December 18, 2024 09:00
@ga-devfront ga-devfront reopened this Dec 18, 2024
@ga-devfront ga-devfront force-pushed the feat/dialog-tempered-files branch from d6fa93e to 4787bfc Compare December 19, 2024 08:19
M0rgan01
M0rgan01 previously approved these changes Dec 19, 2024
View reviewed changes
tblivet
tblivet requested changes Dec 20, 2024
View reviewed changes
_dev/src/scss/components/_index.scss Outdated Show resolved Hide resolved
tblivet
tblivet approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@tblivet tblivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

tblivet
tblivet requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@tblivet tblivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ga-devfront I notice the wording is different on Figma.

classes/UpgradeSelfCheck.php Outdated Show resolved Hide resolved
classes/UpgradeSelfCheck.php Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tblivet tblivet merged commit 693f301 into PrestaShop:dev Dec 20, 2024
37 checks passed
@ga-devfront ga-devfront deleted the feat/dialog-tempered-files branch January 9, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tblivet tblivet tblivet approved these changes

@M0rgan01 M0rgan01 M0rgan01 left review comments

Assignees
No one assigned
Labels
enhancement QA by dev ✔️
Projects
PR Dashboard
Archived in project
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ga-devfront @M0rgan01 @tblivet @ps-jarvis