Merge pull request #813 from ga-devfront/enchancement/add-throw-error

enchancement: Change the logger to throw exception and silent mkdir

classes/UpgradeContainer.php

@@ -609,7 +609,6 @@ public function getWorkspace(): Workspace
         }
 
         $this->workspace = new Workspace(
-            $this->getLogger(),
             $this->getTranslator(),
             $paths
         );

classes/Workspace.php

@@ -27,16 +27,11 @@
 
 namespace PrestaShop\Module\AutoUpgrade;
 
-use PrestaShop\Module\AutoUpgrade\Log\LoggerInterface;
+use Exception;
 use PrestaShop\Module\AutoUpgrade\UpgradeTools\Translator;
 
 class Workspace
 {
-    /**
-     * @var LoggerInterface
-     */
-    private $logger;
-
     /**
      * @var Translator
      */
@@ -50,21 +45,20 @@ class Workspace
     /**
      * @param string[] $paths
      */
-    public function __construct(LoggerInterface $logger, Translator $translator, array $paths)
+    public function __construct(Translator $translator, array $paths)
     {
-        $this->logger = $logger;
         $this->translator = $translator;
         $this->paths = $paths;
     }
 
     public function createFolders(): void
     {
         foreach ($this->paths as $path) {
-            if (!file_exists($path) && !mkdir($path)) {
-                $this->logger->error($this->translator->trans('Unable to create directory %s', [$path]));
+            if (!file_exists($path) && !@mkdir($path)) {
+                throw new Exception($this->translator->trans('Unable to create directory %s', [$path]));
             }
             if (!is_writable($path)) {
-                $this->logger->error($this->translator->trans('Unable to write in the directory "%s"', [$path]));
+                throw new Exception($this->translator->trans('Cannot write to the directory. Please ensure you have the necessary write permissions on "%s".', [$path]));
             }
         }
     }