Add test cases from feedback

PrestaShop · Apr 29, 2024 · c48e92c · c48e92c
1 parent 367f0b1
commit c48e92c
Showing 1 changed file with 22 additions and 5 deletions.
diff --git a/tests/unit/UpgradeContainer/FilesystemAdapterTest.php b/tests/unit/UpgradeContainer/FilesystemAdapterTest.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * Copyright since 2007 PrestaShop SA and Contributors
  * PrestaShop is an International Registered Trademark & Property of PrestaShop SA
@@ -23,6 +24,7 @@
  * @copyright Since 2007 PrestaShop SA and Contributors
  * @license   https://opensource.org/licenses/AFL-3.0 Academic Free License 3.0 (AFL-3.0)
  */
+
 use PHPUnit\Framework\TestCase;
 use PrestaShop\Module\AutoUpgrade\UpgradeContainer;
 
@@ -48,7 +50,9 @@ public function testListFilesInDirForUpgrade()
         );
 
         $actual = $this->filesystemAdapter->listFilesInDir(
-            $pathToRelease, 'upgrade', true
+            $pathToRelease,
+            'upgrade',
+            true
         );
         // TODO: Should try using assertEqualsCanonicalizing after upgrade of PHPUnit
         $this->assertEquals([], array_diff($expected, $actual), "There are more files in the expected array than in the actual list: \n" . implode("\n", array_diff($expected, $actual)));
@@ -65,7 +69,9 @@ public function testListFilesInDirForUpgradeWithTheme()
         );
 
         $actual = $this->filesystemAdapter->listFilesInDir(
-            $pathToRelease, 'upgrade', true
+            $pathToRelease,
+            'upgrade',
+            true
         );
         // TODO: Should try using assertEqualsCanonicalizing after upgrade of PHPUnit
         $this->assertEquals([], array_diff($expected, $actual), "There are more files in the expected array than in the actual list: \n" . implode("\n", array_diff($expected, $actual)));
@@ -82,7 +88,9 @@ public function testFileIsIgnored($file, $fullpath, $process)
                 $file,
                 $this->container->getProperty(UpgradeContainer::PS_ROOT_PATH) . $fullpath,
                 $process,
-                $this->container->getProperty(UpgradeContainer::PS_ROOT_PATH)));
+                $this->container->getProperty(UpgradeContainer::PS_ROOT_PATH)
+            )
+        );
     }
 
     /**
@@ -99,7 +107,8 @@ public function testFileFromReleaseIsIgnored($file, $fullpath, $process)
                 $this->container->getProperty(UpgradeContainer::LATEST_PATH) . $fullpath,
                 $process,
                 $this->container->getProperty(UpgradeContainer::LATEST_PATH)
-            ));
+            )
+        );
     }
 
     /**
@@ -112,7 +121,9 @@ public function testFileIsNotIgnored($file, $fullpath, $process)
                 $file,
                 $this->container->getProperty(UpgradeContainer::PS_ROOT_PATH) . $fullpath,
                 $process,
-                $this->container->getProperty(UpgradeContainer::PS_ROOT_PATH)));
+                $this->container->getProperty(UpgradeContainer::PS_ROOT_PATH)
+            )
+        );
     }
 
     public function ignoredFilesProvider()
@@ -132,6 +143,8 @@ public function ignoredFilesProvider()
             ['controllers', '/override/controllers', 'upgrade'],
             ['modules', '/override/modules', 'upgrade'],
 
+            ['install', '/install', 'upgrade'],
+
             ['parameters.yml', '/app/config/parameters.yml', 'upgrade'],
 
             ['classic', '/themes/classic', 'upgrade'],
@@ -144,6 +157,10 @@ public function notIgnoredFilesProvider()
             ['parameters.yml', '/app/config/parameters.yml', 'backup'],
             ['modules', '/some/unrelated/folder/named/modules', 'upgrade'],
 
+            // The case of files is important.
+            ['Install', '/Install', 'upgrade'],
+            ['DframeInstaller.php', '/vendor/composer/installers/src/Composer/Installers/DframeInstaller.php', 'upgrade'],
+
             ['doge.txt', '/doge.txt', 'upgrade'],
             ['parameters.yml', '/parameters.yml', 'upgrade'],
             ['parameters.yml.dist', '/app/config/parameters.yml.dist', 'upgrade'],