fix: feedback reviews

PrestaShop · Dec 18, 2024 · 207af44 · 207af44
1 parent b552539
commit 207af44
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/_dev/src/ts/pages/UpdatePageVersionChoice.ts b/_dev/src/ts/pages/UpdatePageVersionChoice.ts
@@ -63,7 +63,6 @@ export default class UpdatePageVersionChoice extends UpdatePage {
 
   #onClickDialogLink = async (event: MouseEvent) => {
     const target = event.target as HTMLAnchorElement;
-    console.log('click');
 
     // Checks if the clicked element is an <a> tag pointing towards an ID
     if (!target || target.tagName !== 'A' || !target.hash) {

diff --git a/classes/UpgradeContainer.php b/classes/UpgradeContainer.php
@@ -463,12 +463,10 @@ public function getUpgrader(): Upgrader
             define('_PS_ROOT_DIR_', $this->getProperty(self::PS_ROOT_PATH));
         }
 
-        $currentPrestashopVersion = $this->getProperty(self::PS_VERSION);
-        $phpRequirementService = new PhpVersionResolverService(new DistributionApiService(), $this->getFileLoader(), $currentPrestashopVersion);
         $upgrader = new Upgrader(
-            $phpRequirementService,
+            $this->getPhpVersionResolverService(),
             $this->getUpgradeConfiguration(),
-            $currentPrestashopVersion
+            $this->getProperty(self::PS_VERSION)
         );
 
         $this->upgrader = $upgrader;
@@ -748,8 +746,8 @@ public function getUpgradeSelfCheck(): UpgradeSelfCheck
             $this->getTranslator(),
             $this->getPhpVersionResolverService(),
             $this->getChecksumCompare(),
-            _PS_ROOT_DIR_,
-            _PS_ADMIN_DIR_,
+            $this->psRootDir,
+            $this->adminDir,
             $this->getProperty(UpgradeContainer::WORKSPACE_PATH)
         );