schwarz WIP #133
Closed
schwarz WIP #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnrizzi
commented
Jul 21, 2023
| @@ -130,6 +130,10 @@ class CellCenteredUniformMesh | |||
| const y_coords_type & viewY() const{ return m_y; } | |||
| const z_coords_type & viewZ() const{ return m_z; } | |||
|
|
|||
| int nx() const{ return m_meshDims[0]; }; | |||
| int ny() const{ return m_meshDims[1]; }; | |||
| int nz() const{ return m_meshDims[2]; }; | |||
There was a problem hiding this comment.
these will need to go away because they have no meaning for a generic collection of cells, namely sample mesh. if you need this information, you have to move it to your own code where you know if you are doiing sample mesh or full mesh
fnrizzi
commented
Jul 21, 2023
|
|
||
| f.write("overlap %8d\n" % overlap) | ||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
this whole file should be moved out into your new repo
|
closing this as per discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS -
this is just for checking that the branch does not break existing things and for keeping track of changes